| Message ID | 155677655373.2336373.15845721823034005000.stgit@dwillia2-desk3.amr.corp.intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mm: Sub-section memory hotplug support | expand |
On 02.05.19 07:55, Dan Williams wrote: > The zone type check was a leftover from the cleanup that plumbed altmap > through the memory hotplug path, i.e. commit da024512a1fa "mm: pass the > vmem_altmap to arch_remove_memory and __remove_pages". > > Cc: Michal Hocko <mhocko@suse.com> > Cc: Logan Gunthorpe <logang@deltatee.com> > Cc: David Hildenbrand <david@redhat.com> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> > --- > mm/memory_hotplug.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 0d379da0f1a8..108380e20d8f 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -544,11 +544,8 @@ void __remove_pages(struct zone *zone, unsigned long phys_start_pfn, > unsigned long map_offset = 0; > int sections_to_remove; > > - /* In the ZONE_DEVICE case device driver owns the memory region */ > - if (is_dev_zone(zone)) { > - if (altmap) > - map_offset = vmem_altmap_offset(altmap); > - } > + if (altmap) > + map_offset = vmem_altmap_offset(altmap); > > clear_zone_contiguous(zone); > > That can be picked up independently Reviewed-by: David Hildenbrand <david@redhat.com>
On Wed, May 01, 2019 at 10:55:53PM -0700, Dan Williams wrote: > The zone type check was a leftover from the cleanup that plumbed altmap > through the memory hotplug path, i.e. commit da024512a1fa "mm: pass the > vmem_altmap to arch_remove_memory and __remove_pages". > > Cc: Michal Hocko <mhocko@suse.com> > Cc: Logan Gunthorpe <logang@deltatee.com> > Cc: David Hildenbrand <david@redhat.com> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Oscar Salvador <osalvador@suse.de>
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 0d379da0f1a8..108380e20d8f 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -544,11 +544,8 @@ void __remove_pages(struct zone *zone, unsigned long phys_start_pfn, unsigned long map_offset = 0; int sections_to_remove; - /* In the ZONE_DEVICE case device driver owns the memory region */ - if (is_dev_zone(zone)) { - if (altmap) - map_offset = vmem_altmap_offset(altmap); - } + if (altmap) + map_offset = vmem_altmap_offset(altmap); clear_zone_contiguous(zone);
The zone type check was a leftover from the cleanup that plumbed altmap through the memory hotplug path, i.e. commit da024512a1fa "mm: pass the vmem_altmap to arch_remove_memory and __remove_pages". Cc: Michal Hocko <mhocko@suse.com> Cc: Logan Gunthorpe <logang@deltatee.com> Cc: David Hildenbrand <david@redhat.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- mm/memory_hotplug.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)