| Message ID | 1557417933-15701-2-git-send-email-larry.bassel@oracle.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Share PMDs for FS/DAX on x86 | expand |
> -----Original Message----- > From: Linux-nvdimm <linux-nvdimm-bounces@lists.01.org> On Behalf Of > Larry Bassel > Sent: Thursday, May 09, 2019 11:06 AM > Subject: [PATCH, RFC 1/2] Add config option to enable FS/DAX PMD > sharing > > If enabled, sharing of FS/DAX PMDs will be attempted. > ... > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig ... > > +config MAY_SHARE_FSDAX_PMD > + def_bool y > + Is a config option really necessary - is there any reason to not choose to do this?
On Fri, May 10, 2019 at 9:32 AM Elliott, Robert (Servers) <elliott@hpe.com> wrote: > > > > > -----Original Message----- > > From: Linux-nvdimm <linux-nvdimm-bounces@lists.01.org> On Behalf Of > > Larry Bassel > > Sent: Thursday, May 09, 2019 11:06 AM > > Subject: [PATCH, RFC 1/2] Add config option to enable FS/DAX PMD > > sharing > > > > If enabled, sharing of FS/DAX PMDs will be attempted. > > > ... > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > ... > > > > +config MAY_SHARE_FSDAX_PMD > > +def_bool y > > + > > Is a config option really necessary - is there any reason to > not choose to do this? Agree. Either the arch implementation supports it or it doesn't, I don't see a need for any further configuration flexibility. Seems ARCH_WANT_HUGE_PMD_SHARE should be renamed ARCH_HAS_HUGE_PMD_SHARE and then auto-enable it.
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index e721273..e11702e 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -297,6 +297,9 @@ config ARCH_SUSPEND_POSSIBLE config ARCH_WANT_HUGE_PMD_SHARE def_bool y +config MAY_SHARE_FSDAX_PMD + def_bool y + config ARCH_WANT_GENERAL_HUGETLB def_bool y
If enabled, sharing of FS/DAX PMDs will be attempted. Signed-off-by: Larry Bassel <larry.bassel@oracle.com> --- arch/x86/Kconfig | 3 +++ 1 file changed, 3 insertions(+)