| Message ID | 157256829077.1212326.8726596129631121970.stgit@dwillia2-desk3.amr.corp.intel.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | d7c0d927ad5ca452201eae40f932712ac733c816 |
| Headers | show |
| Series | libnvdimm/pmem: Delete include of nd-core.h | expand |
On Thu, 2019-10-31 at 17:31 -0700, Dan Williams wrote: > The entire point of nd-core.h is to hide functionality that no leaf > driver should touch. In fact, the commit that added it had no need to > include it. > > Fixes: 06e8ccdab15f ("acpi: nfit: Add support for detect platform...") > Cc: Ira Weiny <ira.weiny@intel.com> > Cc: Dave Jiang <dave.jiang@intel.com> > Cc: Vishal Verma <vishal.l.verma@intel.com> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> > --- > drivers/nvdimm/pmem.c | 1 - > 1 file changed, 1 deletion(-) Looks good, Reviewed-by: Vishal Verma <vishal.l.verma@intel.com> > > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c > index 7a6f4501dcda..ad8e4df1282b 100644 > --- a/drivers/nvdimm/pmem.c > +++ b/drivers/nvdimm/pmem.c > @@ -28,7 +28,6 @@ > #include "pmem.h" > #include "pfn.h" > #include "nd.h" > -#include "nd-core.h" > > static struct device *to_dev(struct pmem_device *pmem) > { >
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 7a6f4501dcda..ad8e4df1282b 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -28,7 +28,6 @@ #include "pmem.h" #include "pfn.h" #include "nd.h" -#include "nd-core.h" static struct device *to_dev(struct pmem_device *pmem) {
The entire point of nd-core.h is to hide functionality that no leaf driver should touch. In fact, the commit that added it had no need to include it. Fixes: 06e8ccdab15f ("acpi: nfit: Add support for detect platform...") Cc: Ira Weiny <ira.weiny@intel.com> Cc: Dave Jiang <dave.jiang@intel.com> Cc: Vishal Verma <vishal.l.verma@intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/nvdimm/pmem.c | 1 - 1 file changed, 1 deletion(-)