From patchwork Thu Oct 15 21:06:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 7409921 Return-Path: X-Original-To: patchwork-linux-nvdimm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6E9CD9F1D5 for ; Thu, 15 Oct 2015 21:11:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A5F3E2069F for ; Thu, 15 Oct 2015 21:11:54 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDDE82069D for ; Thu, 15 Oct 2015 21:11:53 +0000 (UTC) Received: from ml01.vlan14.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id D1BBA6056F; Thu, 15 Oct 2015 14:11:53 -0700 (PDT) X-Original-To: linux-nvdimm@lists.01.org Delivered-To: linux-nvdimm@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ml01.01.org (Postfix) with ESMTP id 29A55605A9 for ; Thu, 15 Oct 2015 14:11:53 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 15 Oct 2015 14:11:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,687,1437462000"; d="scan'208";a="581677602" Received: from dwillia2-desk3.jf.intel.com ([10.54.39.39]) by FMSMGA003.fm.intel.com with ESMTP; 15 Oct 2015 14:11:52 -0700 Subject: [PATCH 05/11] ndctl: fix uninitialized variable in configure_namespace From: Dan Williams To: linux-nvdimm@lists.01.org Date: Thu, 15 Oct 2015 17:06:10 -0400 Message-ID: <20151015210610.22046.76914.stgit@dwillia2-desk3.jf.intel.com> In-Reply-To: <20151015210544.22046.31483.stgit@dwillia2-desk3.jf.intel.com> References: <20151015210544.22046.31483.stgit@dwillia2-desk3.jf.intel.com> User-Agent: StGit/0.17.1-9-g687f MIME-Version: 1.0 X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In the pmem case lbasize is zero and the result of ndctl_namespace_set_sector_size() is not relevant. Signed-off-by: Dan Williams --- lib/test-libndctl.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/test-libndctl.c b/lib/test-libndctl.c index e2c72e3c3c25..93ceb358a301 100644 --- a/lib/test-libndctl.c +++ b/lib/test-libndctl.c @@ -651,11 +651,12 @@ static int configure_namespace(struct ndctl_region *region, fprintf(stderr, "%s: set_size failed: %d\n", devname, rc); } - if (lbasize) + if (lbasize) { rc = ndctl_namespace_set_sector_size(ndns, lbasize); - if (rc) - fprintf(stderr, "%s: set_sector_size (%lu) failed: %d\n", - devname, lbasize, rc); + if (rc) + fprintf(stderr, "%s: set_sector_size (%lu) failed: %d\n", + devname, lbasize, rc); + } rc = ndctl_namespace_is_configured(ndns); if (rc < 1)