From patchwork Tue Mar 8 23:36:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 8538321 Return-Path: X-Original-To: patchwork-linux-nvdimm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 45CC39F372 for ; Tue, 8 Mar 2016 23:37:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 770DF201FA for ; Tue, 8 Mar 2016 23:37:01 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AE5B201EF for ; Tue, 8 Mar 2016 23:37:00 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 1D1881A1ED0; Tue, 8 Mar 2016 15:37:14 -0800 (PST) X-Original-To: linux-nvdimm@lists.01.org Delivered-To: linux-nvdimm@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ml01.01.org (Postfix) with ESMTP id 7E7A71A1ED0 for ; Tue, 8 Mar 2016 15:37:13 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 08 Mar 2016 15:36:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,558,1449561600"; d="scan'208";a="760574434" Received: from dwillia2-desk3.jf.intel.com ([10.54.39.14]) by orsmga003.jf.intel.com with ESMTP; 08 Mar 2016 15:37:00 -0800 Subject: [ndctl PATCH 1/8] ndctl: make --enable-local the default From: Dan Williams To: linux-nvdimm@lists.01.org Date: Tue, 08 Mar 2016 15:36:33 -0800 Message-ID: <20160308233633.18628.65570.stgit@dwillia2-desk3.jf.intel.com> In-Reply-To: <20160308233628.18628.13786.stgit@dwillia2-desk3.jf.intel.com> References: <20160308233628.18628.13786.stgit@dwillia2-desk3.jf.intel.com> User-Agent: StGit/0.17.1-9-g687f MIME-Version: 1.0 X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using the kernel provided header is only useful when you want to de-feature ndctl at compile-time. Otherwise, ndctl is responsible for failing gracefully when it finds it is running against an older kernel that is missing newer capabilities. The kernel is responsible for making sure that old ndctl binaries continue to operate on newer kernels. Signed-off-by: Dan Williams --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 3f61b6de250e..9506e8e7dd25 100644 --- a/configure.ac +++ b/configure.ac @@ -85,8 +85,8 @@ PKG_CHECK_MODULES([UUID], [uuid]) PKG_CHECK_MODULES([JSON], [json-c]) AC_ARG_ENABLE([local], - AS_HELP_STRING([--enable-local], [build with local ndctl.h @<:@default=system@:>@]), - [], [enable_local=no]) + AS_HELP_STRING([--disable-local], [build against kernel ndctl.h @<:@default=system@:>@]), + [], [enable_local=yes]) AS_IF([test "x$enable_local" = "xyes"], [], [ AC_CHECK_HEADER([linux/ndctl.h], [