| Message ID | 20170411174233.21902-7-oohall@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 2017-04-12 at 03:42 +1000, Oliver O'Halloran wrote: > Flip the switch. Running around and screaming "IT'S ALIVE" is optional, > but recommended. > > Signed-off-by: Oliver O'Halloran <oohall@gmail.com> > --- > mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 43d000e44424..d696af58f97f 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -724,7 +724,7 @@ config ZONE_DEVICE > depends on MEMORY_HOTPLUG > depends on MEMORY_HOTREMOVE > depends on SPARSEMEM_VMEMMAP > - depends on X86_64 #arch_add_memory() comprehends device memory > + depends on (X86_64 || PPC_BOOK3S_64) #arch_add_memory() comprehends device memory Reviewed-by: Balbir Singh <bsingharora@gmail.com>
Hi Oliver, On Wed, 12 Apr 2017 03:42:30 +1000 Oliver O'Halloran <oohall@gmail.com> wrote: > > Flip the switch. Running around and screaming "IT'S ALIVE" is optional, > but recommended. > > Signed-off-by: Oliver O'Halloran <oohall@gmail.com> > --- > mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 43d000e44424..d696af58f97f 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -724,7 +724,7 @@ config ZONE_DEVICE > depends on MEMORY_HOTPLUG > depends on MEMORY_HOTREMOVE > depends on SPARSEMEM_VMEMMAP > - depends on X86_64 #arch_add_memory() comprehends device memory > + depends on (X86_64 || PPC_BOOK3S_64) #arch_add_memory() comprehends device memory > That's fine, but at what point do we create CONFIG_ARCH_HAVE_ZONE_DEVICE, replace the "depends on <archs/platforms>" above with "depends on ARCH_HAVE_ZONE_DEVICE" and select that from the appropriate places?
Stephen Rothwell <sfr@canb.auug.org.au> writes: > Hi Oliver, > > On Wed, 12 Apr 2017 03:42:30 +1000 Oliver O'Halloran <oohall@gmail.com> wrote: >> >> Flip the switch. Running around and screaming "IT'S ALIVE" is optional, >> but recommended. >> >> Signed-off-by: Oliver O'Halloran <oohall@gmail.com> >> --- >> mm/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/Kconfig b/mm/Kconfig >> index 43d000e44424..d696af58f97f 100644 >> --- a/mm/Kconfig >> +++ b/mm/Kconfig >> @@ -724,7 +724,7 @@ config ZONE_DEVICE >> depends on MEMORY_HOTPLUG >> depends on MEMORY_HOTREMOVE >> depends on SPARSEMEM_VMEMMAP >> - depends on X86_64 #arch_add_memory() comprehends device memory >> + depends on (X86_64 || PPC_BOOK3S_64) #arch_add_memory() comprehends device memory >> > > That's fine, but at what point do we create > CONFIG_ARCH_HAVE_ZONE_DEVICE, replace the "depends on > <archs/platforms>" above with "depends on ARCH_HAVE_ZONE_DEVICE" and > select that from the appropriate places? You mean CONFIG_HAVE_ZONE_DEVICE :) A patch to do that, and update x86, would be a good precursor to this series. It could probably go in right now, and be in place for when this series lands. cheers
diff --git a/mm/Kconfig b/mm/Kconfig index 43d000e44424..d696af58f97f 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -724,7 +724,7 @@ config ZONE_DEVICE depends on MEMORY_HOTPLUG depends on MEMORY_HOTREMOVE depends on SPARSEMEM_VMEMMAP - depends on X86_64 #arch_add_memory() comprehends device memory + depends on (X86_64 || PPC_BOOK3S_64) #arch_add_memory() comprehends device memory help Device memory hotplug support allows for establishing pmem,
Flip the switch. Running around and screaming "IT'S ALIVE" is optional, but recommended. Signed-off-by: Oliver O'Halloran <oohall@gmail.com> --- mm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)