diff mbox series

[ndctl] libndctl: fix bb iterator leak in namespaces

Message ID 20190130231307.5223-1-vishal.l.verma@intel.com (mailing list archive)
State Accepted
Commit 2a6f7e11947959350dcff10df735d616cdd9c1bb
Headers show
Series [ndctl] libndctl: fix bb iterator leak in namespaces | expand

Commit Message

Verma, Vishal L Jan. 30, 2019, 11:13 p.m. UTC 
From: Piotr Balcer <piotr.balcer@intel.com>

We were neglecting to free bb_iterator in free_namespace(), causing a
memory leak. Close the leak by adding the required deallocation.

Signed-off-by: Piotr Balcer <piotr.balcer@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---

via github:pull/80

 ndctl/lib/libndctl.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
index 5eb915f..c9e2875 100644
--- a/ndctl/lib/libndctl.c
+++ b/ndctl/lib/libndctl.c
@@ -461,6 +461,7 @@  static void free_namespace(struct ndctl_namespace *ndns, struct list_head *head)
 	free(ndns->ndns_buf);
 	free(ndns->bdev);
 	free(ndns->alt_name);
+	badblocks_iter_free(&ndns->bb_iter);
 	kmod_module_unref(ndns->module);
 	free(ndns);
 }