| Message ID | 20190228201218.12501-1-toshi.kani@hpe.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 5c9d62d0026a439a785e473859cb3ec9b11a69e9 |
| Headers | show |
| Series | update NFIT flags error message | expand |
On Thu, Feb 28, 2019 at 12:14 PM Toshi Kani <toshi.kani@hpe.com> wrote: > > ACPI NFIT flags field reports major errors on NVDIMM, which need > user's attention. > > Update the current log to a proper error message with dev_err(). > The current message string is kept for grep-compatibility. > Looks good, applied.
diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index e18ade5d74e9..143a77704481 100644 --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -2050,7 +2050,7 @@ static int acpi_nfit_register_dimms(struct acpi_nfit_desc *acpi_desc) if ((mem_flags & ACPI_NFIT_MEM_FAILED_MASK) == 0) continue; - dev_info(acpi_desc->dev, "%s flags:%s%s%s%s%s\n", + dev_err(acpi_desc->dev, "Error found in NVDIMM %s flags:%s%s%s%s%s\n", nvdimm_name(nvdimm), mem_flags & ACPI_NFIT_MEM_SAVE_FAILED ? " save_fail" : "", mem_flags & ACPI_NFIT_MEM_RESTORE_FAILED ? " restore_fail":"",
ACPI NFIT flags field reports major errors on NVDIMM, which need user's attention. Update the current log to a proper error message with dev_err(). The current message string is kept for grep-compatibility. Signed-off-by: Toshi Kani <toshi.kani@hpe.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Robert Elliott <elliott@hpe.com> --- drivers/acpi/nfit/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)