| Message ID | 20190312082034.5846-1-kjlu@umn.edu (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 55c1fc0af29a6c1b92f217b7eb7581a882e0c07c |
| Headers | show |
| Series | nvdimm: namespace_devs: fix a potential NULL pointer dereference | expand |
diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c index 4b077555ac70..6f65261e151f 100644 --- a/drivers/nvdimm/namespace_devs.c +++ b/drivers/nvdimm/namespace_devs.c @@ -2245,9 +2245,12 @@ static struct device *create_namespace_blk(struct nd_region *nd_region, if (!nsblk->uuid) goto blk_err; memcpy(name, nd_label->name, NSLABEL_NAME_LEN); - if (name[0]) + if (name[0]) { nsblk->alt_name = kmemdup(name, NSLABEL_NAME_LEN, GFP_KERNEL); + if (!nsblk->alt_name) + goto blk_err; + } res = nsblk_add_resource(nd_region, ndd, nsblk, __le64_to_cpu(nd_label->dpa)); if (!res)
In case kmemdup fails, the fix goes to blk_err to avoid NULL pointer dereference Signed-off-by: Kangjie Lu <kjlu@umn.edu> --- drivers/nvdimm/namespace_devs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)