| Message ID | 20190401051421.17878-1-aneesh.kumar@linux.ibm.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 67476656febd7ec5f1fe1aeec3c441fcf53b1e45 |
| Headers | show |
| Series | [v2] drivers/dax: Allow to include DEV_DAX_PMEM as builtin | expand |
Hi Dan, "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes: > This move the dependency to DEV_DAX_PMEM_COMPAT such that only > if DEV_DAX_PMEM is built as module we can allow the compat support. > > This allows to test the new code easily in a emulation setup where we > often build things without module support. > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> Any update on this. Can we merge this? > --- > Changes from V1: > * Make sure we only build compat code as module > > drivers/dax/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig > index 5ef624fe3934..a59f338f520f 100644 > --- a/drivers/dax/Kconfig > +++ b/drivers/dax/Kconfig > @@ -23,7 +23,6 @@ config DEV_DAX > config DEV_DAX_PMEM > tristate "PMEM DAX: direct access to persistent memory" > depends on LIBNVDIMM && NVDIMM_DAX && DEV_DAX > - depends on m # until we can kill DEV_DAX_PMEM_COMPAT > default DEV_DAX > help > Support raw access to persistent memory. Note that this > @@ -50,7 +49,7 @@ config DEV_DAX_KMEM > > config DEV_DAX_PMEM_COMPAT > tristate "PMEM DAX: support the deprecated /sys/class/dax interface" > - depends on DEV_DAX_PMEM > + depends on m && DEV_DAX_PMEM=m > default DEV_DAX_PMEM > help > Older versions of the libdaxctl library expect to find all > -- > 2.20.1
On Tue, May 7, 2019 at 4:50 AM Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> wrote: > > > Hi Dan, > > "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes: > > > This move the dependency to DEV_DAX_PMEM_COMPAT such that only > > if DEV_DAX_PMEM is built as module we can allow the compat support. > > > > This allows to test the new code easily in a emulation setup where we > > often build things without module support. > > > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> > > Any update on this. Can we merge this? Applied for the v5.2 pull request.
diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig index 5ef624fe3934..a59f338f520f 100644 --- a/drivers/dax/Kconfig +++ b/drivers/dax/Kconfig @@ -23,7 +23,6 @@ config DEV_DAX config DEV_DAX_PMEM tristate "PMEM DAX: direct access to persistent memory" depends on LIBNVDIMM && NVDIMM_DAX && DEV_DAX - depends on m # until we can kill DEV_DAX_PMEM_COMPAT default DEV_DAX help Support raw access to persistent memory. Note that this @@ -50,7 +49,7 @@ config DEV_DAX_KMEM config DEV_DAX_PMEM_COMPAT tristate "PMEM DAX: support the deprecated /sys/class/dax interface" - depends on DEV_DAX_PMEM + depends on m && DEV_DAX_PMEM=m default DEV_DAX_PMEM help Older versions of the libdaxctl library expect to find all
This move the dependency to DEV_DAX_PMEM_COMPAT such that only if DEV_DAX_PMEM is built as module we can allow the compat support. This allows to test the new code easily in a emulation setup where we often build things without module support. Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> --- Changes from V1: * Make sure we only build compat code as module drivers/dax/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)