| Message ID | 20210205222842.34896-3-uwe@kleine-koenig.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8029968e2ae02361f376751459dc644b45970b40 |
| Headers | show |
| Series | dax-device: Some cleanups | expand |
diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c index 72fc4b9b9ae6..2c9e3f6f615f 100644 --- a/drivers/dax/bus.c +++ b/drivers/dax/bus.c @@ -178,8 +178,12 @@ static int dax_bus_remove(struct device *dev) { struct dax_device_driver *dax_drv = to_dax_drv(dev->driver); struct dev_dax *dev_dax = to_dev_dax(dev); + int ret = 0; - return dax_drv->remove(dev_dax); + if (dax_drv->remove) + ret = dax_drv->remove(dev_dax); + + return ret; } static struct bus_type dax_bus_type = {
If all resources are allocated in .probe() using devm_ functions it might make sense to not provide a .remove() callback. Then the right thing is to just return success. Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> --- drivers/dax/bus.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)