| Message ID | 20220210072828.2930359-2-hch@lst.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | be8a80b3e20e3ecb24c2a5f22cd1c9b120341f3e |
| Headers | show |
| Series | [01/27] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages | expand |
On 2022/2/10 15:28, Christoph Hellwig wrote: > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Logan Gunthorpe <logang@deltatee.com> > Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> > Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> > Reviewed-by: Muchun Song <songmuchun@bytedance.com> > Reviewed-by: Dan Williams <dan.j.williams@intel.com> > --- > mm/memremap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memremap.c b/mm/memremap.c > index 6aa5f0c2d11fda..5f04a0709e436e 100644 > --- a/mm/memremap.c > +++ b/mm/memremap.c > @@ -328,8 +328,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid) > } > break; > case MEMORY_DEVICE_FS_DAX: > - if (!IS_ENABLED(CONFIG_ZONE_DEVICE) || > - IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { > + if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { > WARN(1, "File system DAX not supported\n"); > return ERR_PTR(-EINVAL); > } > LGTM. Thanks. Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
diff --git a/mm/memremap.c b/mm/memremap.c index 6aa5f0c2d11fda..5f04a0709e436e 100644 --- a/mm/memremap.c +++ b/mm/memremap.c @@ -328,8 +328,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid) } break; case MEMORY_DEVICE_FS_DAX: - if (!IS_ENABLED(CONFIG_ZONE_DEVICE) || - IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { + if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) { WARN(1, "File system DAX not supported\n"); return ERR_PTR(-EINVAL); }