| Message ID | 20220823074527.404435-4-vishal.l.verma@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 934d2b34b616566163d80f5844b371ecf88d646a |
| Headers | show |
| Series | cxl: static analysis fixes | expand |
Vishal Verma wrote: > Static analysis points out that there was a chance that 'jdecoder' could > be used while uninitialized in walk_decoders(). Initialize it to NULL to > avoid this. > > Cc: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> > --- > cxl/filter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cxl/filter.c b/cxl/filter.c > index 9a3de8c..56c6599 100644 > --- a/cxl/filter.c > +++ b/cxl/filter.c > @@ -796,7 +796,7 @@ static void walk_decoders(struct cxl_port *port, struct cxl_filter_params *p, > cxl_decoder_foreach(port, decoder) { > const char *devname = cxl_decoder_get_devname(decoder); > struct json_object *jchildregions = NULL; > - struct json_object *jdecoder; > + struct json_object *jdecoder = NULL; Looks good, Reviewed-by: Dan Williams <dan.j.williams@intel.com>
On 8/23/2022 12:45 AM, Vishal Verma wrote: > Static analysis points out that there was a chance that 'jdecoder' could > be used while uninitialized in walk_decoders(). Initialize it to NULL to > avoid this. > > Cc: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > cxl/filter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cxl/filter.c b/cxl/filter.c > index 9a3de8c..56c6599 100644 > --- a/cxl/filter.c > +++ b/cxl/filter.c > @@ -796,7 +796,7 @@ static void walk_decoders(struct cxl_port *port, struct cxl_filter_params *p, > cxl_decoder_foreach(port, decoder) { > const char *devname = cxl_decoder_get_devname(decoder); > struct json_object *jchildregions = NULL; > - struct json_object *jdecoder; > + struct json_object *jdecoder = NULL; > > if (!p->decoders) > goto walk_children;
diff --git a/cxl/filter.c b/cxl/filter.c index 9a3de8c..56c6599 100644 --- a/cxl/filter.c +++ b/cxl/filter.c @@ -796,7 +796,7 @@ static void walk_decoders(struct cxl_port *port, struct cxl_filter_params *p, cxl_decoder_foreach(port, decoder) { const char *devname = cxl_decoder_get_devname(decoder); struct json_object *jchildregions = NULL; - struct json_object *jdecoder; + struct json_object *jdecoder = NULL; if (!p->decoders) goto walk_children;
Static analysis points out that there was a chance that 'jdecoder' could be used while uninitialized in walk_decoders(). Initialize it to NULL to avoid this. Cc: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> --- cxl/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)