| Message ID | 20221212220725.3778201-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dax/hmem: Drop empty platform remove function | expand |
Uwe Kleine-König wrote: > A remove callback just returning 0 is equivalent to no remove callback > at all. So drop the useless function. Looks good, applied.
On Mon, Dec 12, 2022 at 07:46:14PM -0800, Dan Williams wrote: > Uwe Kleine-König wrote: > > A remove callback just returning 0 is equivalent to no remove callback > > at all. So drop the useless function. > > Looks good, applied. Thanks. I wonder why the patch doesn't appear in next though. Is this deliberate? Best regards Uwe
On Thu, Jan 12, 2023 at 10:56:58PM +0100, Uwe Kleine-König wrote: > On Mon, Dec 12, 2022 at 07:46:14PM -0800, Dan Williams wrote: > > Uwe Kleine-König wrote: > > > A remove callback just returning 0 is equivalent to no remove callback > > > at all. So drop the useless function. > > > > Looks good, applied. > > Thanks. I wonder why the patch doesn't appear in next though. Is this > deliberate? Hmm, strange. This patch didn't make it in, but the same patch submitted by you later with a different commit log eventually made it in. v2 from Feb 10 2023 (https://lore.kernel.org/r/167602001664.1924368.9102029637928071240.stgit@dwillia2-xfh.jf.intel.com) was applied as 84fe17f8e9c68a4389c6e89b7ce3b4651b359989, initial series from Feb 05 (https://lore.kernel.org/all/167564542679.847146.17174404738816053065.stgit@dwillia2-xfh.jf.intel.com) I feel a bit humbugged, Uwe
diff --git a/drivers/dax/hmem/hmem.c b/drivers/dax/hmem/hmem.c index 1bf040dbc834..c7351e0dc8ff 100644 --- a/drivers/dax/hmem/hmem.c +++ b/drivers/dax/hmem/hmem.c @@ -44,15 +44,8 @@ static int dax_hmem_probe(struct platform_device *pdev) return 0; } -static int dax_hmem_remove(struct platform_device *pdev) -{ - /* devm handles teardown */ - return 0; -} - static struct platform_driver dax_hmem_driver = { .probe = dax_hmem_probe, - .remove = dax_hmem_remove, .driver = { .name = "hmem", },
A remove callback just returning 0 is equivalent to no remove callback at all. So drop the useless function. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/dax/hmem/hmem.c | 7 ------- 1 file changed, 7 deletions(-) base-commit: 830b3c68c1fb1e9176028d02ef86f3cf76aa2476