| Message ID | 20221213100512.599548-1-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tools/testing/nvdimm: Drop empty platform remove function | expand |
Uwe Kleine-König wrote: > A remove callback just returning 0 is equivalent to no remove callback > at all. So drop the useless function. Looks good, applied to my for-6.3/misc branch for now.
On Tue, Dec 13, 2022 at 11:09:23AM -0800, Dan Williams wrote: > Uwe Kleine-König wrote: > > A remove callback just returning 0 is equivalent to no remove callback > > at all. So drop the useless function. > > Looks good, applied to my for-6.3/misc branch for now. It seems it didn't make it from your for-6.3/misc branch into the mainline (as of v6.4-rc1). What is missing? Best regards Uwe
Hello Dan, On Tue, May 09, 2023 at 07:55:46AM +0200, Uwe Kleine-König wrote: > On Tue, Dec 13, 2022 at 11:09:23AM -0800, Dan Williams wrote: > > Uwe Kleine-König wrote: > > > A remove callback just returning 0 is equivalent to no remove callback > > > at all. So drop the useless function. > > > > Looks good, applied to my for-6.3/misc branch for now. > > It seems it didn't make it from your for-6.3/misc branch into the > mainline (as of v6.4-rc1). What is missing? I don't know what was missing, back then, but the symptom stays: This patch isn't contained in today's next. :-\ I found the patch in the nvdimm patchwork (https://patchwork.kernel.org/project/linux-nvdimm/patch/20221213100512.599548-1-u.kleine-koenig@pengutronix.de/), it was archived. I dared to unarchive it, maybe that helps!? Best regards Uwe
Uwe Kleine-König wrote: > Hello Dan, > > On Tue, May 09, 2023 at 07:55:46AM +0200, Uwe Kleine-König wrote: > > On Tue, Dec 13, 2022 at 11:09:23AM -0800, Dan Williams wrote: > > > Uwe Kleine-König wrote: > > > > A remove callback just returning 0 is equivalent to no remove callback > > > > at all. So drop the useless function. > > > > > > Looks good, applied to my for-6.3/misc branch for now. > > > > It seems it didn't make it from your for-6.3/misc branch into the > > mainline (as of v6.4-rc1). What is missing? > > I don't know what was missing, back then, but the symptom stays: This > patch isn't contained in today's next. :-\ > > I found the patch in the nvdimm patchwork > (https://patchwork.kernel.org/project/linux-nvdimm/patch/20221213100512.599548-1-u.kleine-koenig@pengutronix.de/), > it was archived. I dared to unarchive it, maybe that helps!? Apologies! I queued this and then did not advance the branch. You should see it in linux-next shortly.
diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c index c75abb497a1a..207c19f831aa 100644 --- a/tools/testing/nvdimm/test/nfit.c +++ b/tools/testing/nvdimm/test/nfit.c @@ -3240,11 +3240,6 @@ static int nfit_test_probe(struct platform_device *pdev) return 0; } -static int nfit_test_remove(struct platform_device *pdev) -{ - return 0; -} - static void nfit_test_release(struct device *dev) { struct nfit_test *nfit_test = to_nfit_test(dev); @@ -3259,7 +3254,6 @@ static const struct platform_device_id nfit_test_id[] = { static struct platform_driver nfit_test_driver = { .probe = nfit_test_probe, - .remove = nfit_test_remove, .driver = { .name = KBUILD_MODNAME, },
A remove callback just returning 0 is equivalent to no remove callback at all. So drop the useless function. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- tools/testing/nvdimm/test/nfit.c | 6 ------ 1 file changed, 6 deletions(-)