| Message ID | 20230809154636.11887-1-yangx.jy@fujitsu.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [NDCTL] daxctl: Remove unused mem_zone variable | expand |
On Wed, Aug 09, 2023 at 11:46:36PM +0800, Xiao Yang wrote: > mem_zone variable has never been used so remove it. > > Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> > --- > daxctl/device.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/daxctl/device.c b/daxctl/device.c > index d2d206b..360ae8b 100644 > --- a/daxctl/device.c > +++ b/daxctl/device.c > @@ -59,7 +59,6 @@ enum memory_zone { > MEM_ZONE_MOVABLE, > MEM_ZONE_NORMAL, > }; The enum definition is not used also. Fan > -static enum memory_zone mem_zone = MEM_ZONE_MOVABLE; > > enum device_action { > ACTION_RECONFIG, > @@ -469,8 +468,6 @@ static const char *parse_device_options(int argc, const char **argv, > align = __parse_size64(param.align, &units); > } else if (strcmp(param.mode, "system-ram") == 0) { > reconfig_mode = DAXCTL_DEV_MODE_RAM; > - if (param.no_movable) > - mem_zone = MEM_ZONE_NORMAL; > } else if (strcmp(param.mode, "devdax") == 0) { > reconfig_mode = DAXCTL_DEV_MODE_DEVDAX; > if (param.no_online) { > @@ -494,9 +491,6 @@ static const char *parse_device_options(int argc, const char **argv, > align = __parse_size64(param.align, &units); > /* fall through */ > case ACTION_ONLINE: > - if (param.no_movable) > - mem_zone = MEM_ZONE_NORMAL; > - /* fall through */ > case ACTION_DESTROY: > case ACTION_OFFLINE: > case ACTION_DISABLE: > -- > 2.40.1 >
On 2023/8/11 1:02, Fan Ni wrote: > The enum definition is not used also. Hi Fan, Good catch, I will send v2 patch to remove it. Best Regards, Xiao Yang > > Fan
diff --git a/daxctl/device.c b/daxctl/device.c index d2d206b..360ae8b 100644 --- a/daxctl/device.c +++ b/daxctl/device.c @@ -59,7 +59,6 @@ enum memory_zone { MEM_ZONE_MOVABLE, MEM_ZONE_NORMAL, }; -static enum memory_zone mem_zone = MEM_ZONE_MOVABLE; enum device_action { ACTION_RECONFIG, @@ -469,8 +468,6 @@ static const char *parse_device_options(int argc, const char **argv, align = __parse_size64(param.align, &units); } else if (strcmp(param.mode, "system-ram") == 0) { reconfig_mode = DAXCTL_DEV_MODE_RAM; - if (param.no_movable) - mem_zone = MEM_ZONE_NORMAL; } else if (strcmp(param.mode, "devdax") == 0) { reconfig_mode = DAXCTL_DEV_MODE_DEVDAX; if (param.no_online) { @@ -494,9 +491,6 @@ static const char *parse_device_options(int argc, const char **argv, align = __parse_size64(param.align, &units); /* fall through */ case ACTION_ONLINE: - if (param.no_movable) - mem_zone = MEM_ZONE_NORMAL; - /* fall through */ case ACTION_DESTROY: case ACTION_OFFLINE: case ACTION_DISABLE:
mem_zone variable has never been used so remove it. Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> --- daxctl/device.c | 6 ------ 1 file changed, 6 deletions(-)