| Message ID | 20230811011618.17290-1-yangx.jy@fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Vishal Verma |
| Headers | show |
| Series | [v2] daxctl: Remove unused memory_zone and mem_zone | expand |
Ping. ^_^ -----Original Message----- From: Xiao Yang <yangx.jy@fujitsu.com> Sent: 2023年8月11日 9:16 To: vishal.l.verma@intel.com; fan.ni@gmx.us; nvdimm@lists.linux.dev Cc: linux-cxl@vger.kernel.org; Yang, Xiao/杨 晓 <yangx.jy@fujitsu.com> Subject: [PATCH v2] daxctl: Remove unused memory_zone and mem_zone The enum memory_zone definition and mem_zone variable have never been used so remove them. Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> --- daxctl/device.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/daxctl/device.c b/daxctl/device.c index d2d206b..8391343 100644 --- a/daxctl/device.c +++ b/daxctl/device.c @@ -55,12 +55,6 @@ static unsigned long flags; static struct mapping *maps = NULL; static long long nmaps = -1; -enum memory_zone { - MEM_ZONE_MOVABLE, - MEM_ZONE_NORMAL, -}; -static enum memory_zone mem_zone = MEM_ZONE_MOVABLE; - enum device_action { ACTION_RECONFIG, ACTION_ONLINE, @@ -469,8 +463,6 @@ static const char *parse_device_options(int argc, const char **argv, align = __parse_size64(param.align, &units); } else if (strcmp(param.mode, "system-ram") == 0) { reconfig_mode = DAXCTL_DEV_MODE_RAM; - if (param.no_movable) - mem_zone = MEM_ZONE_NORMAL; } else if (strcmp(param.mode, "devdax") == 0) { reconfig_mode = DAXCTL_DEV_MODE_DEVDAX; if (param.no_online) { @@ -494,9 +486,6 @@ static const char *parse_device_options(int argc, const char **argv, align = __parse_size64(param.align, &units); /* fall through */ case ACTION_ONLINE: - if (param.no_movable) - mem_zone = MEM_ZONE_NORMAL; - /* fall through */ case ACTION_DESTROY: case ACTION_OFFLINE: case ACTION_DISABLE: -- 2.40.1
Xiao Yang (Fujitsu) wrote: > Ping. ^_^ > > -----Original Message----- > From: Xiao Yang <yangx.jy@fujitsu.com> > Sent: 2023年8月11日 9:16 > To: vishal.l.verma@intel.com; fan.ni@gmx.us; nvdimm@lists.linux.dev > Cc: linux-cxl@vger.kernel.org; Yang, Xiao/杨 晓 <yangx.jy@fujitsu.com> > Subject: [PATCH v2] daxctl: Remove unused memory_zone and mem_zone > > The enum memory_zone definition and mem_zone variable have never been used so remove them. NIT: I don't know that they have never been used but they certainly seem to have been moved to the library. > > Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Hi All, Kindly Ping. Best Regards, Xiao Yang On 2023/12/1 12:12, Ira Weiny wrote: > Xiao Yang (Fujitsu) wrote: >> Ping. ^_^ >> >> -----Original Message----- >> From: Xiao Yang <yangx.jy@fujitsu.com> >> Sent: 2023年8月11日 9:16 >> To: vishal.l.verma@intel.com; fan.ni@gmx.us; nvdimm@lists.linux.dev >> Cc: linux-cxl@vger.kernel.org; Yang, Xiao/杨 晓 <yangx.jy@fujitsu.com> >> Subject: [PATCH v2] daxctl: Remove unused memory_zone and mem_zone >> >> The enum memory_zone definition and mem_zone variable have never been used so remove them. > > NIT: I don't know that they have never been used but they certainly seem > to have been moved to the library. > >> >> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> > > Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Xiao Yang wrote: > The enum memory_zone definition and mem_zone variable > have never been used so remove them. > > Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> Looks good to me: Reviewed-by: Dan Williams <dan.j.williams@intel.com>
diff --git a/daxctl/device.c b/daxctl/device.c index d2d206b..8391343 100644 --- a/daxctl/device.c +++ b/daxctl/device.c @@ -55,12 +55,6 @@ static unsigned long flags; static struct mapping *maps = NULL; static long long nmaps = -1; -enum memory_zone { - MEM_ZONE_MOVABLE, - MEM_ZONE_NORMAL, -}; -static enum memory_zone mem_zone = MEM_ZONE_MOVABLE; - enum device_action { ACTION_RECONFIG, ACTION_ONLINE, @@ -469,8 +463,6 @@ static const char *parse_device_options(int argc, const char **argv, align = __parse_size64(param.align, &units); } else if (strcmp(param.mode, "system-ram") == 0) { reconfig_mode = DAXCTL_DEV_MODE_RAM; - if (param.no_movable) - mem_zone = MEM_ZONE_NORMAL; } else if (strcmp(param.mode, "devdax") == 0) { reconfig_mode = DAXCTL_DEV_MODE_DEVDAX; if (param.no_online) { @@ -494,9 +486,6 @@ static const char *parse_device_options(int argc, const char **argv, align = __parse_size64(param.align, &units); /* fall through */ case ACTION_ONLINE: - if (param.no_movable) - mem_zone = MEM_ZONE_NORMAL; - /* fall through */ case ACTION_DESTROY: case ACTION_OFFLINE: case ACTION_DISABLE:
The enum memory_zone definition and mem_zone variable have never been used so remove them. Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> --- daxctl/device.c | 11 ----------- 1 file changed, 11 deletions(-)