From patchwork Fri Mar 1 01:31:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alison Schofield X-Patchwork-Id: 13577823 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F6D32B9D2 for ; Fri, 1 Mar 2024 01:31:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709256688; cv=none; b=EfXyi6ZMi/1EWT8lqmaQfejxxV2lFQRzZ/j1ad7vnC32ZTjdtrxn1zFKH1G/NkidUgtXiukRBmhUoa0HylCcGKL0oMQcDBHHyJ84EKK6/0roY7EHkLkkTmHv1O3OwwWvItRY1T12P4TCCCMxIxf3x1W3cqN+nZ1cYwtsimZvmtg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709256688; c=relaxed/simple; bh=TVx9IeXgQLRLu1JF0qCJbumBV4fjmWg+KAIK17Za3jw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DZ0t+TUz5bzfCCFKqJtjPt7SlVaqtfeFci4J0GFpR0ibMXCJVELuGh1q2q9/ojBmQMSIBBOWOCOha35HFQJ4zoxE4GrG30w40NrHT0OAIe9deQUELbDdPjWXpgiaLSZmPe4qZHEGBbWYeoq00ba5/voVzTcbdhfEZKh9kKN/q1Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FEW8WpIN; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FEW8WpIN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709256686; x=1740792686; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TVx9IeXgQLRLu1JF0qCJbumBV4fjmWg+KAIK17Za3jw=; b=FEW8WpIN+rV3S9IDb8z77UhgGMvFZUMaMQPk6I6OCxmj7qQIjaGPGSxF bGHJarieq9goqlk8En74e7pVATde7XAFGZuOEVkWdozcJMi56uW2K6Ut+ +klodnlYcZydd4zGjO3abpG+N4cPqqJpwZSz7quGknMiRmYEZjvPSZYka ddRkAVGVEE5zgRB8P0rlK5f4wNo8ATM3zMnbN8+1g5QOUbMjIBN9Ip16n fFcaJWd6drsYKgezqQQ4UIDgUx6ZGXdu+Kw9ObsW9ffaAvEEfznKz9P6T bqf9cbyY4/nRsksoeOJMxoss2ZTWninSm3TTV2jDmw8j3OuGk8qs4FeSs Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10999"; a="14343106" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="14343106" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 17:31:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="7952656" Received: from aschofie-mobl2.amr.corp.intel.com (HELO localhost) ([10.212.136.104]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 17:31:24 -0800 From: alison.schofield@intel.com To: Vishal Verma Cc: Alison Schofield , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Dave Jiang Subject: [ndctl PATCH v9 1/7] libcxl: add interfaces for GET_POISON_LIST mailbox commands Date: Thu, 29 Feb 2024 17:31:16 -0800 Message-Id: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Alison Schofield CXL devices maintain a list of locations that are poisoned or result in poison if the addresses are accessed by the host. Per the spec (CXL 3.1 8.2.9.9.4.1), the device returns the Poison List as a set of Media Error Records that include the source of the error, the starting device physical address and length. Trigger the retrieval of the poison list by writing to the memory device sysfs attribute: trigger_poison_list. The CXL driver only offers triggering per memdev, so the trigger by region interface offered here is a convenience API that triggers a poison list retrieval for each memdev contributing to a region. int cxl_memdev_trigger_poison_list(struct cxl_memdev *memdev); int cxl_region_trigger_poison_list(struct cxl_region *region); The resulting poison records are logged as kernel trace events named 'cxl_poison'. Signed-off-by: Alison Schofield Reviewed-by: Dave Jiang --- cxl/lib/libcxl.c | 47 ++++++++++++++++++++++++++++++++++++++++++++++ cxl/lib/libcxl.sym | 2 ++ cxl/libcxl.h | 2 ++ 3 files changed, 51 insertions(+) diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c index 725240a17473..1537a33d370e 100644 --- a/cxl/lib/libcxl.c +++ b/cxl/lib/libcxl.c @@ -1710,6 +1710,53 @@ CXL_EXPORT int cxl_memdev_disable_invalidate(struct cxl_memdev *memdev) return 0; } +CXL_EXPORT int cxl_memdev_trigger_poison_list(struct cxl_memdev *memdev) +{ + struct cxl_ctx *ctx = cxl_memdev_get_ctx(memdev); + char *path = memdev->dev_buf; + int len = memdev->buf_len, rc; + + if (snprintf(path, len, "%s/trigger_poison_list", + memdev->dev_path) >= len) { + err(ctx, "%s: buffer too small\n", + cxl_memdev_get_devname(memdev)); + return -ENXIO; + } + rc = sysfs_write_attr(ctx, path, "1\n"); + if (rc < 0) { + fprintf(stderr, + "%s: Failed write sysfs attr trigger_poison_list\n", + cxl_memdev_get_devname(memdev)); + return rc; + } + return 0; +} + +CXL_EXPORT int cxl_region_trigger_poison_list(struct cxl_region *region) +{ + struct cxl_memdev_mapping *mapping; + int rc; + + cxl_mapping_foreach(region, mapping) { + struct cxl_decoder *decoder; + struct cxl_memdev *memdev; + + decoder = cxl_mapping_get_decoder(mapping); + if (!decoder) + continue; + + memdev = cxl_decoder_get_memdev(decoder); + if (!memdev) + continue; + + rc = cxl_memdev_trigger_poison_list(memdev); + if (rc) + return rc; + } + + return 0; +} + CXL_EXPORT int cxl_memdev_enable(struct cxl_memdev *memdev) { struct cxl_ctx *ctx = cxl_memdev_get_ctx(memdev); diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym index 2cbceb3a95da..72a50be7601f 100644 --- a/cxl/lib/libcxl.sym +++ b/cxl/lib/libcxl.sym @@ -276,4 +276,6 @@ global: cxl_cmd_alert_config_set_enable_alert_actions; cxl_cmd_new_set_alert_config; cxl_memdev_wait_sanitize; + cxl_memdev_trigger_poison_list; + cxl_region_trigger_poison_list; } LIBCXL_6; diff --git a/cxl/libcxl.h b/cxl/libcxl.h index 98612ba71b29..352b3a866f63 100644 --- a/cxl/libcxl.h +++ b/cxl/libcxl.h @@ -461,6 +461,8 @@ enum cxl_setpartition_mode { int cxl_cmd_partition_set_mode(struct cxl_cmd *cmd, enum cxl_setpartition_mode mode); +int cxl_memdev_trigger_poison_list(struct cxl_memdev *memdev); +int cxl_region_trigger_poison_list(struct cxl_region *region); int cxl_cmd_alert_config_set_life_used_prog_warn_threshold(struct cxl_cmd *cmd, int threshold);