From patchwork Tue Jun 18 13:21:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Ujfalusi X-Patchwork-Id: 11001687 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DCAA96C5 for ; Tue, 18 Jun 2019 13:21:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE94E28974 for ; Tue, 18 Jun 2019 13:21:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C33142890F; Tue, 18 Jun 2019 13:21:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 494FC28A1E for ; Tue, 18 Jun 2019 13:21:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728945AbfFRNVb (ORCPT ); Tue, 18 Jun 2019 09:21:31 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:34022 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729285AbfFRNVb (ORCPT ); Tue, 18 Jun 2019 09:21:31 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5IDLEIC000444; Tue, 18 Jun 2019 08:21:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1560864074; bh=WtkFs1CYQDfDygNNCGi17BiapjOqf3PWLziDa0PnWu0=; h=From:To:CC:Subject:Date; b=GeSOjSveNLsoxDohP8XZcFdOL1zhmR68M6T3Ub2aOGvNvZ+foQ6sKuJZ3nJBZWKqE /APuQXgEb/u2DRSNuClg2qOKer4LSVPeglQpKJWcpzGDSj1vnDdnnED9+gJKbBvLUx uPhYpIAfYy/P5tm5Z2ZsG/DNoljbXfZI0CPV2L8E= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5IDLEgR072988 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 18 Jun 2019 08:21:14 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 18 Jun 2019 08:21:13 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 18 Jun 2019 08:21:13 -0500 Received: from feketebors.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5IDLBKj026006; Tue, 18 Jun 2019 08:21:12 -0500 From: Peter Ujfalusi To: CC: , , , Subject: [PATCH v4 0/3] dmaengine: ti: edma: Polled completion support Date: Tue, 18 Jun 2019 16:21:45 +0300 Message-ID: <20190618132148.26468-1-peter.ujfalusi@ti.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, Change since v3: - fix DMA pointer tracking for memcpy - completion polling is only done when it is asked by not providing DMA_PREP_INTERRUPT for memcpy Changes since v2: - Fix typo in the comment for patch 0 Changes since v1: - Cleanup patch for the array register handling - typo fixed in patch2 commit message The code around the array register access was pretty confusing for the first look, so clean them up first then use the cleaner way in the polled handling. When a DMA client driver does not set the DMA_PREP_INTERRUPT because it does not want to use interrupts for DMA completion or because it can not rely on DMA interrupts due to executing the memcpy when interrupts are disabled it will poll the status of the transfer. Since we can not tell from any EDMA register that the transfer is completed, we can only know that the paRAM set has been sent to TPTC for processing we need to check the residue of the transfer, if it is 0 then the transfer is completed. The polled completion can bve tested by applying: https://patchwork.kernel.org/patch/10966499/ Enabling the memcpy for EDMA and run the dmatest with polled = 1. Or, enable the EDMA memcpy support and boot up any dra7 family device with display enabled. The workaround for DMM errata i878 uses polled DMA memcpy. Regards, Peter --- Peter Ujfalusi (3): dmaengine: ti: edma: Clean up the 2x32bit array register accesses dmaengine: ti: edma: Correct the residue calculation (fix for memcpy) dmaengine: ti: edma: Support for polled (memcpy) completion drivers/dma/ti/edma.c | 174 ++++++++++++++++++++++++++++-------------- 1 file changed, 117 insertions(+), 57 deletions(-)