| Message ID | 20191007170801.27647-1-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix SPI module alias for panels used by omapdrm | expand |
Hi Laurent. On Mon, Oct 07, 2019 at 08:07:56PM +0300, Laurent Pinchart wrote: > Hello, > > This patch series fixes a module alias issue with the five recently > added panel drivers used by omapdrm. > > Before those panel drivers, omapdrm had custom drivers for the panels, > and prefixed the OF compatible strings with an "omapdss," prefix. The > SPI device IDs are constructed by stripping the OF compatible string > from the prefix, resulting in the "omapdss," prefix being removed, but > the subsequence OF vendor prefix being kept. The SPI drivers thus had > modules aliases that contained the vendor prefix. > > Now that the panels are supported by standard drivers and the "omapdss," > prefix is removed, the SPI device IDs are stripped from the OF vendor > prefix. As the new panel drivers copied the module aliases from the > omapdrm-specific drivers, they contain the vendor prefix in their SPI > module aliases, and are thus not loaded automatically. > > Fix this by removing the vendor prefix from the SPI modules aliases in > the drivers. For consistency reason, the manual module aliases are also > moved to use an SPI module table. Good explanation - thanks. > > These patches are based on the drm-misc-fixes branch as they fix v5.4 > regressions. > > Laurent Pinchart (5): > drm/panel: lg-lb035q02: Fix SPI alias > drm/panel: nec-nl8048hl11: Fix SPI alias > drm/panel: sony-acx565akm: Fix SPI alias > drm/panel: tpo-td028ttec1: Fix SPI alias > drm/panel: tpo-td043mtea1: Fix SPI alias Full series is: Acked-by: Sam Ravnborg <sam@ravnborg.org> I expect someone else to pick them up or that you apply them. Sam
Hi, On Mon, Oct 07, 2019 at 08:07:56PM +0300, Laurent Pinchart wrote: > This patch series fixes a module alias issue with the five recently > added panel drivers used by omapdrm. For the whole series: Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian
Hi Sam, On Mon, Oct 07, 2019 at 07:22:56PM +0200, Sam Ravnborg wrote: > Hi Laurent. > On Mon, Oct 07, 2019 at 08:07:56PM +0300, Laurent Pinchart wrote: > > Hello, > > > > This patch series fixes a module alias issue with the five recently > > added panel drivers used by omapdrm. > > > > Before those panel drivers, omapdrm had custom drivers for the panels, > > and prefixed the OF compatible strings with an "omapdss," prefix. The > > SPI device IDs are constructed by stripping the OF compatible string > > from the prefix, resulting in the "omapdss," prefix being removed, but > > the subsequence OF vendor prefix being kept. The SPI drivers thus had > > modules aliases that contained the vendor prefix. > > > > Now that the panels are supported by standard drivers and the "omapdss," > > prefix is removed, the SPI device IDs are stripped from the OF vendor > > prefix. As the new panel drivers copied the module aliases from the > > omapdrm-specific drivers, they contain the vendor prefix in their SPI > > module aliases, and are thus not loaded automatically. > > > > Fix this by removing the vendor prefix from the SPI modules aliases in > > the drivers. For consistency reason, the manual module aliases are also > > moved to use an SPI module table. > > Good explanation - thanks. > > > These patches are based on the drm-misc-fixes branch as they fix v5.4 > > regressions. > > > > Laurent Pinchart (5): > > drm/panel: lg-lb035q02: Fix SPI alias > > drm/panel: nec-nl8048hl11: Fix SPI alias > > drm/panel: sony-acx565akm: Fix SPI alias > > drm/panel: tpo-td028ttec1: Fix SPI alias > > drm/panel: tpo-td043mtea1: Fix SPI alias > > Full series is: > Acked-by: Sam Ravnborg <sam@ravnborg.org> > > I expect someone else to pick them up or that you apply them. I'd like someone to test the patches first if possible :-) Tomi, could you then pick these up as v5.4 fixes ?
On 07/10/2019 20:22, Sam Ravnborg wrote: > Hi Laurent. > On Mon, Oct 07, 2019 at 08:07:56PM +0300, Laurent Pinchart wrote: >> Hello, >> >> This patch series fixes a module alias issue with the five recently >> added panel drivers used by omapdrm. >> >> Before those panel drivers, omapdrm had custom drivers for the panels, >> and prefixed the OF compatible strings with an "omapdss," prefix. The >> SPI device IDs are constructed by stripping the OF compatible string >> from the prefix, resulting in the "omapdss," prefix being removed, but >> the subsequence OF vendor prefix being kept. The SPI drivers thus had >> modules aliases that contained the vendor prefix. >> >> Now that the panels are supported by standard drivers and the "omapdss," >> prefix is removed, the SPI device IDs are stripped from the OF vendor >> prefix. As the new panel drivers copied the module aliases from the >> omapdrm-specific drivers, they contain the vendor prefix in their SPI >> module aliases, and are thus not loaded automatically. >> >> Fix this by removing the vendor prefix from the SPI modules aliases in >> the drivers. For consistency reason, the manual module aliases are also >> moved to use an SPI module table. > > Good explanation - thanks. > >> >> These patches are based on the drm-misc-fixes branch as they fix v5.4 >> regressions. >> >> Laurent Pinchart (5): >> drm/panel: lg-lb035q02: Fix SPI alias >> drm/panel: nec-nl8048hl11: Fix SPI alias >> drm/panel: sony-acx565akm: Fix SPI alias >> drm/panel: tpo-td028ttec1: Fix SPI alias >> drm/panel: tpo-td043mtea1: Fix SPI alias > > Full series is: > Acked-by: Sam Ravnborg <sam@ravnborg.org> > > I expect someone else to pick them up or that you apply them. Thanks! I've pushed these to drm-misc-fixes. Tomi