From patchwork Thu Sep 30 06:29:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 12527391 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 674ACC433EF for ; Thu, 30 Sep 2021 06:29:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F42961528 for ; Thu, 30 Sep 2021 06:29:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348285AbhI3Ga6 (ORCPT ); Thu, 30 Sep 2021 02:30:58 -0400 Received: from muru.com ([72.249.23.125]:38848 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348252AbhI3Ga6 (ORCPT ); Thu, 30 Sep 2021 02:30:58 -0400 Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id 8EF1080CF; Thu, 30 Sep 2021 06:29:43 +0000 (UTC) From: Tony Lindgren To: Greg Kroah-Hartman Cc: Andy Shevchenko , Jiri Slaby , Johan Hovold , Vignesh Raghavendra , linux-serial@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCHv2 0/4] Get rid of pm_runtime_irq_safe() for 8250_omap Date: Thu, 30 Sep 2021 09:29:02 +0300 Message-Id: <20210930062906.58937-1-tony@atomide.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi, Here are v2 patches to get rid of pm_runtime_irq_safe() for the 8250_omap driver. Based on comments from Andy and Johan, I improved a bunch of things as listed below. For removing the pm_runtime_irq_safe() usage, serial TX is the last remaining issue. We deal with TX by waking up the port and returning 0 bytes written from write_room() and write() if the port is not available because of PM runtime autoidle. This series also removes the dependency to Andy's pending generic serial layer PM runtime patches, and hopefully makes that work a bit easier :) Regards, Tony Changes since v1: - Separated out line discipline patches, n_tty -EAGAIN change I still need to retest - Changed prep_tx() to more generic wakeup() as also flow control needs it - Changed over to using wakeup() with device driver runtime PM instead of write_room() - Added runtime_suspended flag for drivers and generic serial layer PM to use Tony Lindgren (4): serial: core: Add wakeup() and start_pending_tx() for power management serial: 8250: Implement wakeup for TX and use it for 8250_omap serial: 8250_omap: Require a valid wakeirq for deeper idle states serial: 8250_omap: Drop the use of pm_runtime_irq_safe() Documentation/driver-api/serial/driver.rst | 9 ++++ drivers/tty/serial/8250/8250_omap.c | 42 +++++++++++----- drivers/tty/serial/8250/8250_port.c | 35 +++++++++++++- drivers/tty/serial/serial_core.c | 56 +++++++++++++++++++++- include/linux/serial_core.h | 3 ++ 5 files changed, 131 insertions(+), 14 deletions(-)