From patchwork Thu Jul 20 05:10:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 13319739 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E150EB64DA for ; Thu, 20 Jul 2023 05:10:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229503AbjGTFKc (ORCPT ); Thu, 20 Jul 2023 01:10:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbjGTFKa (ORCPT ); Thu, 20 Jul 2023 01:10:30 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E1364EC for ; Wed, 19 Jul 2023 22:10:29 -0700 (PDT) Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id 4658980F7; Thu, 20 Jul 2023 05:10:28 +0000 (UTC) From: Tony Lindgren Cc: Andy Shevchenko , Dhruva Gole , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org Subject: [PATCH v2 0/3] Serial core controller port device name fixes Date: Thu, 20 Jul 2023 08:10:13 +0300 Message-ID: <20230720051021.14961-1-tony@atomide.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org A few issues have been found with device naming for the serial core controller port device. These issues currently affect mostly the output for /sys/bus/serial-base/devices, but need to be also fixed to avoid port addressing issues later on. It would be good to get these fixes into the -rc cycle to avoid folks possibly trying to use the incorrect sysfs port device names for finding uart ports for example. Regards, Tony Changes since v1: - Port id cannot be negative as noted by Jiri - Controller id cannot be negative as noted by Andy - Port name is missing the controller instance as noted by Andy Tony Lindgren (3): serial: core: Controller id cannot be negative serial: core: Fix serial core port id to not use port->line serial: core: Fix serial core controller port name to show controller id drivers/tty/serial/8250/8250_core.c | 2 ++ drivers/tty/serial/serial_base_bus.c | 33 ++++++++++++++++++---------- include/linux/serial_core.h | 3 ++- 3 files changed, 25 insertions(+), 13 deletions(-)