| Message ID | 20240213-arm-dt-cleanups-v1-0-f2dee1292525@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | dts: Fix dtc interrupt warnings | expand |
On Tue, Feb 13, 2024 at 01:34:24PM -0600, Rob Herring wrote: > I had a branch with most of these changes sitting in my tree for some > time. Geert's asking about some errors not getting found prompted me to > clean it up and send it out. This series fixes all* interrupt related > warnings and enables the check by default. > > SoC maintainers, Can you please take this series directly. > > Rob > > *There's a few Renesas warnings still Geert said he would fix. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Rob Herring (6): > arm64: dts: freescale: Disable interrupt_map check > arm: dts: Fix dtc interrupt_provider warnings > arm64: dts: Fix dtc interrupt_provider warnings > arm: dts: Fix dtc interrupt_map warnings > arm64: dts: qcom: Fix interrupt-map cell sizes > dtc: Enable dtc interrupt_provider check Only fixing it for arm, Sadge. Co-incidentally I noticed there was one for riscv while looking at Krzysztof's underscore in node name patch earlier, so I'd already written a patch to fix it :)
On Tue, Feb 13, 2024 at 2:27 PM Conor Dooley <conor@kernel.org> wrote: > > On Tue, Feb 13, 2024 at 01:34:24PM -0600, Rob Herring wrote: > > I had a branch with most of these changes sitting in my tree for some > > time. Geert's asking about some errors not getting found prompted me to > > clean it up and send it out. This series fixes all* interrupt related > > warnings and enables the check by default. > > > > SoC maintainers, Can you please take this series directly. > > > > Rob > > > > *There's a few Renesas warnings still Geert said he would fix. > > > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > Rob Herring (6): > > arm64: dts: freescale: Disable interrupt_map check > > arm: dts: Fix dtc interrupt_provider warnings > > arm64: dts: Fix dtc interrupt_provider warnings > > arm: dts: Fix dtc interrupt_map warnings > > arm64: dts: qcom: Fix interrupt-map cell sizes > > dtc: Enable dtc interrupt_provider check > > Only fixing it for arm, Sadge. I was assuming you had things in order. ;) > Co-incidentally I noticed there was one for riscv while looking at > Krzysztof's underscore in node name patch earlier, so I'd already > written a patch to fix it :) See, I was right. Actually, I did remember to check right after I sent this and noticed the same. For powerpc, no one else can be bothered to care, so neither do I. I think powerpc has been spewing dtc warnings by default for some time now. Rob
Hi Rob, On Tue, Feb 13, 2024 at 8:35 PM Rob Herring <robh@kernel.org> wrote: > I had a branch with most of these changes sitting in my tree for some > time. Geert's asking about some errors not getting found prompted me to > clean it up and send it out. This series fixes all* interrupt related > warnings and enables the check by default. > *There's a few Renesas warnings still Geert said he would fix. Thanks, fix sent https://lore.kernel.org/r/a351e503ea97fb1af68395843f513925ff1bdf26.1707922460.git.geert+renesas@glider.be > dtc: Enable dtc interrupt_provider check > scripts/Makefile.lib | 3 +-- Just wondering, can the remaining disabler be removed, too? Documentation/devicetree/bindings/Makefile: -Wno-interrupt_provider \ Gr{oetje,eeting}s, Geert
On Wed, Feb 14, 2024 at 9:01 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Rob, > > On Tue, Feb 13, 2024 at 8:35 PM Rob Herring <robh@kernel.org> wrote: > > I had a branch with most of these changes sitting in my tree for some > > time. Geert's asking about some errors not getting found prompted me to > > clean it up and send it out. This series fixes all* interrupt related > > warnings and enables the check by default. > > > *There's a few Renesas warnings still Geert said he would fix. > > Thanks, fix sent > https://lore.kernel.org/r/a351e503ea97fb1af68395843f513925ff1bdf26.1707922460.git.geert+renesas@glider.be > > > dtc: Enable dtc interrupt_provider check > > > scripts/Makefile.lib | 3 +-- > > Just wondering, can the remaining disabler be removed, too? > > Documentation/devicetree/bindings/Makefile: -Wno-interrupt_provider \ I was too. Shockingly, that too will require some fixes. Though I remember when configuring the warnings for bindings, trying to make them stricter. So there must have been some case where no-interrupt_provider was needed. It may have been related to how we parse interrupts in examples, but that changed back when switching to validate dtbs directly. Rob
I had a branch with most of these changes sitting in my tree for some time. Geert's asking about some errors not getting found prompted me to clean it up and send it out. This series fixes all* interrupt related warnings and enables the check by default. SoC maintainers, Can you please take this series directly. Rob *There's a few Renesas warnings still Geert said he would fix. Signed-off-by: Rob Herring <robh@kernel.org> --- Rob Herring (6): arm64: dts: freescale: Disable interrupt_map check arm: dts: Fix dtc interrupt_provider warnings arm64: dts: Fix dtc interrupt_provider warnings arm: dts: Fix dtc interrupt_map warnings arm64: dts: qcom: Fix interrupt-map cell sizes dtc: Enable dtc interrupt_provider check arch/arm/boot/dts/amazon/alpine.dtsi | 1 - arch/arm/boot/dts/aspeed/aspeed-g4.dtsi | 14 -------------- arch/arm/boot/dts/aspeed/aspeed-g5.dtsi | 15 +-------------- arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 18 ++---------------- arch/arm/boot/dts/broadcom/bcm-cygnus.dtsi | 3 +++ arch/arm/boot/dts/broadcom/bcm-hr2.dtsi | 1 + arch/arm/boot/dts/broadcom/bcm-nsp.dtsi | 2 ++ .../boot/dts/intel/ixp/intel-ixp42x-gateway-7001.dts | 2 ++ .../dts/intel/ixp/intel-ixp42x-goramo-multilink.dts | 2 ++ arch/arm/boot/dts/marvell/kirkwood-l-50.dts | 2 ++ arch/arm/boot/dts/nuvoton/nuvoton-wpcm450.dtsi | 2 ++ arch/arm/boot/dts/nvidia/tegra30-apalis-v1.1.dtsi | 1 - arch/arm/boot/dts/nvidia/tegra30-apalis.dtsi | 1 - arch/arm/boot/dts/nvidia/tegra30-colibri.dtsi | 1 - arch/arm/boot/dts/nxp/imx/imx6q-b850v3.dts | 3 --- arch/arm/boot/dts/nxp/imx/imx6q-bx50v3.dtsi | 2 +- arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi | 1 - arch/arm/boot/dts/nxp/imx/imx6qdl-colibri.dtsi | 1 - arch/arm/boot/dts/nxp/imx/imx6qdl-emcon.dtsi | 1 - arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 1 + .../boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 1 + arch/arm/boot/dts/nxp/imx/imx7d-pico-dwarf.dts | 1 + arch/arm/boot/dts/nxp/vf/vf610-zii-dev-rev-b.dts | 1 + arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 8 ++++---- arch/arm/boot/dts/st/stm32429i-eval.dts | 1 - arch/arm/boot/dts/st/stm32mp157c-dk2.dts | 1 - arch/arm/boot/dts/ti/omap/am5729-beagleboneai.dts | 1 - arch/arm64/boot/dts/amazon/alpine-v2.dtsi | 1 - arch/arm64/boot/dts/amazon/alpine-v3.dtsi | 1 - arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi | 1 + arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi | 1 + arch/arm64/boot/dts/freescale/Makefile | 19 +++++++++++++++++++ arch/arm64/boot/dts/lg/lg1312.dtsi | 1 - arch/arm64/boot/dts/lg/lg1313.dtsi | 1 - arch/arm64/boot/dts/marvell/armada-ap80x.dtsi | 1 - arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 1 + arch/arm64/boot/dts/qcom/ipq6018.dtsi | 8 ++++---- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 16 ++++++++-------- arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 4 ++++ scripts/Makefile.lib | 3 +-- 40 files changed, 65 insertions(+), 81 deletions(-) --- base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d change-id: 20240213-arm-dt-cleanups-76bb726de948 Best regards,