mbox series

[0/5] ARM: dts: fix faulty ohci/ehci node names

Message ID 20250330121326.9069-7-wsa+renesas@sang-engineering.com (mailing list archive)
Headers show
Series ARM: dts: fix faulty ohci/ehci node names | expand

Message

Wolfram Sang March 30, 2025, 12:13 p.m. UTC 
After I fixed this for the at91-boards I was interested in, I let the
scripts run for the other boards, too, of course. Here is the outcome.
49 less dtbs_check errors. Build bots were happy. No dependencies, I
suggest sub-trees apply them on their own. Thanks!

Happy hacking,

   Wolfram

Wolfram Sang (5):
  ARM: dts: marvell: fix faulty ohci/ehci node names
  ARM: dts: nxp: lpc: fix faulty ohci/ehci node names
  ARM: dts: st: fix faulty ohci/ehci node names
  ARM: dts: ti: omap: fix faulty ohci/ehci node names
  ARM: dts: vt8500: fix faulty ohci/ehci node names

 arch/arm/boot/dts/marvell/kirkwood-db.dtsi             | 2 +-
 arch/arm/boot/dts/marvell/kirkwood-dir665.dts          | 2 +-
 arch/arm/boot/dts/marvell/kirkwood-mv88f6281gtw-ge.dts | 2 +-
 arch/arm/boot/dts/marvell/kirkwood.dtsi                | 2 +-
 arch/arm/boot/dts/marvell/orion5x.dtsi                 | 4 ++--
 arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi                 | 2 +-
 arch/arm/boot/dts/st/spear1310-evb.dts                 | 8 ++++----
 arch/arm/boot/dts/st/spear1340-evb.dts                 | 8 ++++----
 arch/arm/boot/dts/st/spear13xx.dtsi                    | 8 ++++----
 arch/arm/boot/dts/st/spear300-evb.dts                  | 6 +++---
 arch/arm/boot/dts/st/spear310-evb.dts                  | 6 +++---
 arch/arm/boot/dts/st/spear320-evb.dts                  | 6 +++---
 arch/arm/boot/dts/st/spear320-hmi.dts                  | 6 +++---
 arch/arm/boot/dts/st/spear3xx.dtsi                     | 6 +++---
 arch/arm/boot/dts/st/spear600.dtsi                     | 8 ++++----
 arch/arm/boot/dts/ti/omap/omap3.dtsi                   | 4 ++--
 arch/arm/boot/dts/ti/omap/omap4-l4.dtsi                | 4 ++--
 arch/arm/boot/dts/ti/omap/omap5-l4.dtsi                | 4 ++--
 arch/arm/boot/dts/vt8500/vt8500.dtsi                   | 2 +-
 arch/arm/boot/dts/vt8500/wm8505.dtsi                   | 2 +-
 arch/arm/boot/dts/vt8500/wm8650.dtsi                   | 2 +-
 arch/arm/boot/dts/vt8500/wm8750.dtsi                   | 2 +-
 arch/arm/boot/dts/vt8500/wm8850.dtsi                   | 2 +-
 23 files changed, 49 insertions(+), 49 deletions(-)

Comments

Krzysztof Kozlowski March 30, 2025, 3:57 p.m. UTC | #1 
On 30/03/2025 14:13, Wolfram Sang wrote:
> After I fixed this for the at91-boards I was interested in, I let the
> scripts run for the other boards, too, of course. Here is the outcome.
> 49 less dtbs_check errors. Build bots were happy. No dependencies, I
> suggest sub-trees apply them on their own. Thanks!
> 

For this and the rest patches, I would not call it "fix" in the subject
because there is no bug to fix here and you just might confuse AUTOSEL.
What's more backporting this might actually cause regressions, because
in rare cases node name is an ABI. Therefore avoid calling anything here
fix.

You just adjust or align them with coding style or what
bindings/dtschema expect (but it expects due to generic naming
convention which is still just convention).

Best regards,
Krzysztof
Krzysztof Kozlowski March 30, 2025, 3:59 p.m. UTC | #2 
On 30/03/2025 17:57, Krzysztof Kozlowski wrote:
> On 30/03/2025 14:13, Wolfram Sang wrote:
>> After I fixed this for the at91-boards I was interested in, I let the
>> scripts run for the other boards, too, of course. Here is the outcome.
>> 49 less dtbs_check errors. Build bots were happy. No dependencies, I
>> suggest sub-trees apply them on their own. Thanks!
>>
> 
> For this and the rest patches, I would not call it "fix" in the subject
> because there is no bug to fix here and you just might confuse AUTOSEL.
> What's more backporting this might actually cause regressions, because
> in rare cases node name is an ABI. Therefore avoid calling anything here
> fix.
> 
> You just adjust or align them with coding style or what
> bindings/dtschema expect (but it expects due to generic naming
> convention which is still just convention).
> 

And I forgot:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Wolfram Sang March 30, 2025, 4:38 p.m. UTC | #3 
> You just adjust or align them with coding style or what
> bindings/dtschema expect (but it expects due to generic naming
> convention which is still just convention).

Ack, I will "fix" :) the subjects and add your tag. Thanks!