[v2,0/6] mmc: core: extend mmc_fixup_device and transplant ti,wl1251 quirks from to be retired omap_hsmmc

Message

H. Nikolaus Schaller Nov. 10, 2021, 5:17 p.m. UTC

PATCH V2 2021-11-10 18:17:11:
* remove setting card->ocr = 0x80 because it is no longer needed (by H. Nikolaus Schaller <[e-mail]>)
* include patch "mmc: core: Fixup storing of OCR for MMC_QUIRK_NONSTD_SDIO" by Ulf Hansson <[e-mail]>

PATCH V1 2021-11-09 11:59:08:
* merge call of mmc_fixup_device for sdio into other commit (suggested by Ulf Hansson <[e-mail]>)
* do not call mmc_fixup_device(card, sdio_card_init_methods) for mmc and sd interfaces, just sdio (suggested by Ulf Hansson <[e-mail]>)
* do not use a matching list but a single string constant (suggested by Ulf Hansson <[e-mail]>)
* switched to "[PATCH v1]" (suggested by Ulf Hansson <[e-mail]>)

RFC V4 2021-11-05 10:05:51:
* remove const from char *const * (Ulf Hansson <[e-mail]>)
* use for_each_child_of_node() to scan compatible children (Ulf Hansson <[e-mail]>)
(see: https://lore.kernel.org/lkml/[e-mail]/)

RFC V3 2021-11-03 14:00:13:
* patches have been split into smaller ones a little further
* propose a new macro for setup of device tree compatible quirks
* directly include patches by [e-mail]
  in this series

RFC V2 2021-11-01 10:24:26:
* reworked to not misuse mmc_select_card() but add a call to
  mmc_fixup_device() right after where host->ops->init_card
  was called before to apply the wl1251 specific quirks.
  Device tree matching is done by a new table passed to mmc_fixup_device().
  suggested by: [e-mail]
  based on patches by: [e-mail]

RFC V1 2021-10-06 13:24:13:


H. Nikolaus Schaller (3):
  mmc: core: provide macro and table to match the device tree to apply
    quirks
  mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc
  mmc: host: omap_hsmmc: revert special init for wl1251

Jérôme Pouiller (2):
  mmc: core: rewrite mmc_fixup_device()
  mmc: core: allow to match the device tree to apply quirks

Ulf Hansson (1):
  mmc: core: Fixup storing of OCR for MMC_QUIRK_NONSTD_SDIO

 drivers/mmc/core/card.h       | 36 ++++++++++++++++++++
 drivers/mmc/core/quirks.h     | 64 +++++++++++++++++++++++++----------
 drivers/mmc/core/sdio.c       |  5 ++-
 drivers/mmc/host/omap_hsmmc.c | 36 --------------------
 4 files changed, 87 insertions(+), 54 deletions(-)

Comments

Ulf Hansson Nov. 11, 2021, 12:10 p.m. UTC | #1

On Wed, 10 Nov 2021 at 18:17, H. Nikolaus Schaller <[e-mail]> wrote:
>
> PATCH V2 2021-11-10 18:17:11:
> * remove setting card->ocr = 0x80 because it is no longer needed (by H. Nikolaus Schaller <[e-mail]>)
> * include patch "mmc: core: Fixup storing of OCR for MMC_QUIRK_NONSTD_SDIO" by Ulf Hansson <[e-mail]>
>
> PATCH V1 2021-11-09 11:59:08:
> * merge call of mmc_fixup_device for sdio into other commit (suggested by Ulf Hansson <[e-mail]>)
> * do not call mmc_fixup_device(card, sdio_card_init_methods) for mmc and sd interfaces, just sdio (suggested by Ulf Hansson <[e-mail]>)
> * do not use a matching list but a single string constant (suggested by Ulf Hansson <[e-mail]>)
> * switched to "[PATCH v1]" (suggested by Ulf Hansson <[e-mail]>)
>
> RFC V4 2021-11-05 10:05:51:
> * remove const from char *const * (Ulf Hansson <[e-mail]>)
> * use for_each_child_of_node() to scan compatible children (Ulf Hansson <[e-mail]>)
> (see: https://lore.kernel.org/lkml/[e-mail]/)
>
> RFC V3 2021-11-03 14:00:13:
> * patches have been split into smaller ones a little further
> * propose a new macro for setup of device tree compatible quirks
> * directly include patches by [e-mail]
>   in this series
>
> RFC V2 2021-11-01 10:24:26:
> * reworked to not misuse mmc_select_card() but add a call to
>   mmc_fixup_device() right after where host->ops->init_card
>   was called before to apply the wl1251 specific quirks.
>   Device tree matching is done by a new table passed to mmc_fixup_device().
>   suggested by: [e-mail]
>   based on patches by: [e-mail]
>
> RFC V1 2021-10-06 13:24:13:
>
>
> H. Nikolaus Schaller (3):
>   mmc: core: provide macro and table to match the device tree to apply
>     quirks
>   mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc
>   mmc: host: omap_hsmmc: revert special init for wl1251
>
> Jérôme Pouiller (2):
>   mmc: core: rewrite mmc_fixup_device()
>   mmc: core: allow to match the device tree to apply quirks
>
> Ulf Hansson (1):
>   mmc: core: Fixup storing of OCR for MMC_QUIRK_NONSTD_SDIO
>
>  drivers/mmc/core/card.h       | 36 ++++++++++++++++++++
>  drivers/mmc/core/quirks.h     | 64 +++++++++++++++++++++++++----------
>  drivers/mmc/core/sdio.c       |  5 ++-
>  drivers/mmc/host/omap_hsmmc.c | 36 --------------------
>  4 files changed, 87 insertions(+), 54 deletions(-)
>

This looks good to me, I will queue it up as soon as rc1 is out, thanks!

Kind regards
Uffe

H. Nikolaus Schaller Nov. 11, 2021, 1:50 p.m. UTC | #2

> Am 11.11.2021 um 13:10 schrieb Ulf Hansson <[e-mail]>:
> 
> On Wed, 10 Nov 2021 at 18:17, H. Nikolaus Schaller <[e-mail]> wrote:
>> 
>> 
>> drivers/mmc/core/card.h       | 36 ++++++++++++++++++++
>> drivers/mmc/core/quirks.h     | 64 +++++++++++++++++++++++++----------
>> drivers/mmc/core/sdio.c       |  5 ++-
>> drivers/mmc/host/omap_hsmmc.c | 36 --------------------
>> 4 files changed, 87 insertions(+), 54 deletions(-)
>> 
> 
> This looks good to me, I will queue it up as soon as rc1 is out, thanks!

Thanks!

Best regards,
Nikolaus

Tony Lindgren Nov. 11, 2021, 2:11 p.m. UTC | #3

* H. Nikolaus Schaller <[e-mail]> [211111 13:51]:
> 
> 
> > Am 11.11.2021 um 13:10 schrieb Ulf Hansson <[e-mail]>:
> > 
> > On Wed, 10 Nov 2021 at 18:17, H. Nikolaus Schaller <[e-mail]> wrote:
> >> 
> >> 
> >> drivers/mmc/core/card.h       | 36 ++++++++++++++++++++
> >> drivers/mmc/core/quirks.h     | 64 +++++++++++++++++++++++++----------
> >> drivers/mmc/core/sdio.c       |  5 ++-
> >> drivers/mmc/host/omap_hsmmc.c | 36 --------------------
> >> 4 files changed, 87 insertions(+), 54 deletions(-)
> >> 
> > 
> > This looks good to me, I will queue it up as soon as rc1 is out, thanks!
> 
> Thanks!

Thanks for sorting this out!

Tony