From patchwork Thu Mar 5 13:54:24 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ari Kauppi X-Patchwork-Id: 10071 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n25Dt8HV028567 for ; Thu, 5 Mar 2009 13:55:08 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751646AbZCENzH (ORCPT ); Thu, 5 Mar 2009 08:55:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754039AbZCENzH (ORCPT ); Thu, 5 Mar 2009 08:55:07 -0500 Received: from smtp.nokia.com ([192.100.105.134]:54523 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbZCENzF (ORCPT ); Thu, 5 Mar 2009 08:55:05 -0500 Received: from esebh106.NOE.Nokia.com (esebh106.ntc.nokia.com [172.21.138.213]) by mgw-mx09.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id n25Dt1eX031789; Thu, 5 Mar 2009 07:55:02 -0600 Received: from vaebh104.NOE.Nokia.com ([10.160.244.30]) by esebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 5 Mar 2009 15:54:55 +0200 Received: from mgw-int02.ntc.nokia.com ([172.21.143.97]) by vaebh104.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Thu, 5 Mar 2009 15:54:51 +0200 Received: from localhost.localdomain (ouped11936.nmp.nokia.com [172.23.119.36]) by mgw-int02.ntc.nokia.com (Switch-3.2.5/Switch-3.2.5) with ESMTP id n25DsnH0027836; Thu, 5 Mar 2009 15:54:50 +0200 From: Ari Kauppi To: linux-i2c@vger.kernel.org Cc: linux-omap@vger.kernel.org Subject: [PATCH] I2C: Call request_irq with IRQF_DISABLED Date: Thu, 5 Mar 2009 15:54:24 +0200 Message-Id: <1236261264-16053-1-git-send-email-Ext-Ari.Kauppi@nokia.com> X-Mailer: git-send-email 1.5.6.5 X-OriginalArrivalTime: 05 Mar 2009 13:54:51.0337 (UTC) FILETIME=[F470F390:01C99D99] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org I have observed some Spurious IRQ's for I2C1 when all kernel hacking options (and thus LOCKDEP) are disabled. Applying Richard Woodruff's 'I2C bug fixes for L-O and L-Z' seems to help but IRQF_DISABLED is needed for proper behaviour. Signed-off-by: Ari Kauppi Acked-by: Felipe Balbi --- drivers/i2c/busses/i2c-omap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 0c3ed41..18af43f 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -847,7 +847,7 @@ omap_i2c_probe(struct platform_device *pdev) omap_i2c_init(dev); isr = (dev->rev < OMAP_I2C_REV_2) ? omap_i2c_rev1_isr : omap_i2c_isr; - r = request_irq(dev->irq, isr, 0, pdev->name, dev); + r = request_irq(dev->irq, isr, IRQF_DISABLED, pdev->name, dev); if (r) { dev_err(dev->dev, "failure requesting irq %i\n", dev->irq);