From patchwork Mon Apr 20 21:28:06 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 19063 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n3KLSVTr015487 for ; Mon, 20 Apr 2009 21:28:32 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755527AbZDTV2Q (ORCPT ); Mon, 20 Apr 2009 17:28:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751212AbZDTV2P (ORCPT ); Mon, 20 Apr 2009 17:28:15 -0400 Received: from mail-bw0-f163.google.com ([209.85.218.163]:35946 "EHLO mail-bw0-f163.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755527AbZDTV2P (ORCPT ); Mon, 20 Apr 2009 17:28:15 -0400 Received: by bwz7 with SMTP id 7so1451648bwz.37 for ; Mon, 20 Apr 2009 14:28:12 -0700 (PDT) Received: by 10.204.51.200 with SMTP id e8mr5771867bkg.175.1240262892825; Mon, 20 Apr 2009 14:28:12 -0700 (PDT) Received: from localhost (a91-154-121-48.elisa-laajakaista.fi [91.154.121.48]) by mx.google.com with ESMTPS id 21sm11189574fkx.26.2009.04.20.14.28.10 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 20 Apr 2009 14:28:11 -0700 (PDT) From: Amit Kucheria To: linux-omap@vger.kernel.org Subject: [PATCH] twl4030: Add some error checking to twl4030 init Date: Tue, 21 Apr 2009 00:28:06 +0300 Message-Id: <1240262886-24538-1-git-send-email-amit.kucheria@verdurent.com> X-Mailer: git-send-email 1.6.0.4 In-Reply-To: References: Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Whitespace-fixed version and passed through checkpatch.pl Check for return values of i2c read/write operations and size of scripts being uploaded to TWL4030 Signed-off-by: Amit Kucheria Acked-by: Peter De Schrijver --- drivers/mfd/twl4030-core.c | 2 +- drivers/mfd/twl4030-power.c | 49 ++++++++++++++++++++++++++++++------------ 2 files changed, 36 insertions(+), 15 deletions(-) diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c index 769b34b..067b02e 100644 --- a/drivers/mfd/twl4030-core.c +++ b/drivers/mfd/twl4030-core.c @@ -358,7 +358,7 @@ EXPORT_SYMBOL(twl4030_i2c_read); int twl4030_i2c_write_u8(u8 mod_no, u8 value, u8 reg) { - /* 2 bytes offset 1 contains the data offset 0 is used by i2c_write */ + /* 2 bytes: offset 1 contains the data, offset 0 is used by i2c_write */ u8 temp_buffer[2] = { 0 }; /* offset 1 contains the data */ temp_buffer[1] = value; diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c index 9dc493b..b4b636d 100644 --- a/drivers/mfd/twl4030-power.c +++ b/drivers/mfd/twl4030-power.c @@ -257,36 +257,38 @@ static int __init config_warmreset_sequence(u8 address) return err; } -void twl4030_configure_resource(struct twl4030_resconfig *rconfig) +static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig) { int rconfig_addr; + int err; u8 type; if (rconfig->resource > NUM_OF_RESOURCES) { printk(KERN_ERR "TWL4030 Resource %d does not exist\n", rconfig->resource); - return; + return -EINVAL; } rconfig_addr = res_config_addrs[rconfig->resource]; /* Set resource group */ - if (rconfig->devgroup >= 0) - twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, + err = twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, rconfig->devgroup << 5, rconfig_addr + DEVGROUP_OFFSET); + if (err < 0) { + printk(KERN_ERR "TWL4030 failed to program devgroup"); + return err; + } /* Set resource types */ - - if (twl4030_i2c_read_u8(TWL4030_MODULE_PM_RECEIVER, - &type, - rconfig_addr + TYPE_OFFSET) < 0) { - printk(KERN_ERR - "TWL4030 Resource %d type could not read\n", + err = twl4030_i2c_read_u8(TWL4030_MODULE_PM_RECEIVER, &type, + rconfig_addr + TYPE_OFFSET); + if (err < 0) { + printk(KERN_ERR "TWL4030 Resource %d type could not be read\n", rconfig->resource); - return; + return err; } if (rconfig->type >= 0) { @@ -299,8 +301,14 @@ void twl4030_configure_resource(struct twl4030_resconfig *rconfig) type |= rconfig->type2 << 3; } - twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, + err = twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, type, rconfig_addr + TYPE_OFFSET); + if (err < 0) { + printk(KERN_ERR "TWL4030 failed to program resource type"); + return err; + } + + return 0; } @@ -309,6 +317,12 @@ static int __init load_triton_script(struct twl4030_script *tscript) u8 address = triton_next_free_address; int err; + /* Make sure the script isn't going beyond last valid address */ + if ((address + tscript->size) > (END_OF_SCRIPT-1)) { + printk(KERN_ERR "TWL4030 script too big error\n"); + return -EINVAL; + } + err = twl4030_write_script(address, tscript->script, tscript->size); if (err) return err; @@ -346,15 +360,22 @@ void __init twl4030_power_init(struct twl4030_power_data *triton2_scripts) for (i = 0; i < triton2_scripts->size; i++) { err = load_triton_script(triton2_scripts->scripts[i]); - if (err) + if (err < 0) { + printk(KERN_ERR "TWL4030 failed to load scripts"); break; + } } resconfig = triton2_scripts->resource_config; if (resconfig) { while (resconfig->resource) { - twl4030_configure_resource(resconfig); + err = twl4030_configure_resource(resconfig); resconfig++; + if (err < 0) { + printk(KERN_ERR + "TWL4030 failed to configure resource"); + break; + } } }