From patchwork Thu Jul 2 14:21:08 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ameya Palande X-Patchwork-Id: 33684 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n62EMOgE003747 for ; Thu, 2 Jul 2009 14:22:24 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754154AbZGBOWS (ORCPT ); Thu, 2 Jul 2009 10:22:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754229AbZGBOWS (ORCPT ); Thu, 2 Jul 2009 10:22:18 -0400 Received: from smtp.nokia.com ([192.100.122.230]:42768 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753590AbZGBOWS (ORCPT ); Thu, 2 Jul 2009 10:22:18 -0400 Received: from vaebh105.NOE.Nokia.com (vaebh105.europe.nokia.com [10.160.244.31]) by mgw-mx03.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id n62EMBv9030741; Thu, 2 Jul 2009 17:22:12 +0300 Received: from esebh102.NOE.Nokia.com ([172.21.138.183]) by vaebh105.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 2 Jul 2009 17:21:18 +0300 Received: from mgw-da02.ext.nokia.com ([147.243.128.26]) by esebh102.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Thu, 2 Jul 2009 17:21:17 +0300 Received: from localhost.localdomain (esdhcp041160.research.nokia.com [172.21.41.160]) by mgw-da02.ext.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id n62EL585006485; Thu, 2 Jul 2009 17:21:11 +0300 From: Ameya Palande To: linux-omap@vger.kernel.org Cc: x0095840@ti.com, h-kanigeri2@ti.com, ext-phil.2.carmody@nokia.com Subject: [PATCH 4/4] DSPBRIDGE: Remove unnecessary conditions from some for loops Date: Thu, 2 Jul 2009 17:21:08 +0300 Message-Id: <1246544468-14546-4-git-send-email-ameya.palande@nokia.com> X-Mailer: git-send-email 1.6.2.4 In-Reply-To: <1246544468-14546-3-git-send-email-ameya.palande@nokia.com> References: <1246544468-14546-1-git-send-email-ameya.palande@nokia.com> <1246544468-14546-2-git-send-email-ameya.palande@nokia.com> <1246544468-14546-3-git-send-email-ameya.palande@nokia.com> X-OriginalArrivalTime: 02 Jul 2009 14:21:17.0834 (UTC) FILETIME=[5D396EA0:01C9FB20] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The status cannot be a failure value at the start of the loops, and the only changes to a failure state are accompanied by a break or goto, so these conditions are always true. Signed-off-by: Phil Carmody --- drivers/dsp/bridge/pmgr/wcd.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dsp/bridge/pmgr/wcd.c b/drivers/dsp/bridge/pmgr/wcd.c index 2fd9f8c..a1bd2c7 100644 --- a/drivers/dsp/bridge/pmgr/wcd.c +++ b/drivers/dsp/bridge/pmgr/wcd.c @@ -900,7 +900,7 @@ u32 PROCWRAP_Load(union Trapped_Args *args) goto func_cont; } - for (i = 0; DSP_SUCCEEDED(status) && (i < count); i++) { + for (i = 0; i < count; i++) { if (argv[i] != NULL) { /* User space pointer to argument */ temp = (char *) argv[i]; @@ -941,7 +941,7 @@ u32 PROCWRAP_Load(union Trapped_Args *args) envp = NULL; goto func_cont; } - for (i = 0; DSP_SUCCEEDED(status) && (envp[i] != NULL); i++) { + for (i = 0; envp[i] != NULL; i++) { /* User space pointer to argument */ temp = (char *)envp[i]; len = strlen_user((char *)temp);