From patchwork Wed Jul 15 14:56:26 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ameya Palande X-Patchwork-Id: 35703 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n6FEvHxC024936 for ; Wed, 15 Jul 2009 14:57:17 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752525AbZGOO5P (ORCPT ); Wed, 15 Jul 2009 10:57:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755221AbZGOO5P (ORCPT ); Wed, 15 Jul 2009 10:57:15 -0400 Received: from smtp.nokia.com ([192.100.122.230]:18134 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752525AbZGOO5O (ORCPT ); Wed, 15 Jul 2009 10:57:14 -0400 Received: from vaebh106.NOE.Nokia.com (vaebh106.europe.nokia.com [10.160.244.32]) by mgw-mx03.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id n6FEuiQB024098; Wed, 15 Jul 2009 17:56:59 +0300 Received: from vaebh104.NOE.Nokia.com ([10.160.244.30]) by vaebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 15 Jul 2009 17:56:33 +0300 Received: from mgw-sa01.ext.nokia.com ([147.243.1.47]) by vaebh104.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Wed, 15 Jul 2009 17:56:33 +0300 Received: from localhost.localdomain (esdhcp04048.research.nokia.com [172.21.40.48]) by mgw-sa01.ext.nokia.com (Switch-3.2.6/Switch-3.2.6) with ESMTP id n6FEuQeW018779; Wed, 15 Jul 2009 17:56:31 +0300 From: Ameya Palande To: linux-omap@vger.kernel.org Cc: omar.ramirez@ti.com, x0095840@ti.com, nm@ti.com, hiroshi.doyu@nokia.com Subject: [PATCH 03/13] DSPBRIDGE: Remove unnecessary conditions from some for loops Date: Wed, 15 Jul 2009 17:56:26 +0300 Message-Id: <1247669795-23895-4-git-send-email-ameya.palande@nokia.com> X-Mailer: git-send-email 1.6.2.4 In-Reply-To: <1247669795-23895-3-git-send-email-ameya.palande@nokia.com> References: <1247669795-23895-1-git-send-email-ameya.palande@nokia.com> <1247669795-23895-2-git-send-email-ameya.palande@nokia.com> <1247669795-23895-3-git-send-email-ameya.palande@nokia.com> X-OriginalArrivalTime: 15 Jul 2009 14:56:33.0555 (UTC) FILETIME=[71A99630:01CA055C] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The status cannot be a failure value at the start of the loops, and the only changes to a failure state are accompanied by a break or goto, so these conditions are always true. Signed-off-by: Phil Carmody Acked-by: Fernando Guzman Lugo --- drivers/dsp/bridge/pmgr/wcd.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dsp/bridge/pmgr/wcd.c b/drivers/dsp/bridge/pmgr/wcd.c index 8111b60..441130c 100644 --- a/drivers/dsp/bridge/pmgr/wcd.c +++ b/drivers/dsp/bridge/pmgr/wcd.c @@ -900,7 +900,7 @@ u32 PROCWRAP_Load(union Trapped_Args *args) goto func_cont; } - for (i = 0; DSP_SUCCEEDED(status) && (i < count); i++) { + for (i = 0; i < count; i++) { if (argv[i]) { /* User space pointer to argument */ temp = (char *) argv[i]; @@ -941,7 +941,7 @@ u32 PROCWRAP_Load(union Trapped_Args *args) envp = NULL; goto func_cont; } - for (i = 0; DSP_SUCCEEDED(status) && envp[i]; i++) { + for (i = 0; envp[i]; i++) { /* User space pointer to argument */ temp = (char *)envp[i]; /* len is increased by 1 to accommodate NULL */