From patchwork Thu Aug 13 02:01:20 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: vikram pandita X-Patchwork-Id: 40963 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7D22M1R004721 for ; Thu, 13 Aug 2009 02:02:22 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751086AbZHMCCP (ORCPT ); Wed, 12 Aug 2009 22:02:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751204AbZHMCCP (ORCPT ); Wed, 12 Aug 2009 22:02:15 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:54783 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751086AbZHMCCP (ORCPT ); Wed, 12 Aug 2009 22:02:15 -0400 Received: from dlep33.itg.ti.com ([157.170.170.112]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id n7D22BnT018632 for ; Wed, 12 Aug 2009 21:02:16 -0500 Received: from legion.dal.design.ti.com (localhost [127.0.0.1]) by dlep33.itg.ti.com (8.13.7/8.13.7) with ESMTP id n7D228xM003457; Wed, 12 Aug 2009 21:02:08 -0500 (CDT) Received: from vip-tid (lta0307903-128247075087.am.dhcp.ti.com [128.247.75.87]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id n7D227Z05777; Wed, 12 Aug 2009 21:02:07 -0500 (CDT) Received: from vip-tid (localhost.localdomain [127.0.0.1]) by vip-tid (Postfix) with ESMTP id A051229CAEC; Wed, 12 Aug 2009 21:01:22 -0500 (CDT) Received: (from vikram@localhost) by vip-tid (8.14.3/8.14.3/Submit) id n7D21MkG003573; Wed, 12 Aug 2009 21:01:22 -0500 X-Authentication-Warning: vip-tid: vikram set sender to vikram.pandita@ti.com using -f From: Vikram Pandita To: linux-omap@vger.kernel.org Cc: Vikram Pandita Subject: [PATCH v2] OMAP2/3: DMA errata correction Date: Wed, 12 Aug 2009 21:01:20 -0500 Message-Id: <1250128880-1517-1-git-send-email-vikram.pandita@ti.com> X-Mailer: git-send-email 1.6.3.3.334.g916e1 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org This errata is valid for: OMAP2420 Errata 1.85 Impacts all 2420 ES rev OMAP2430 Errata 1.10 Impacts only ES1.0 Description: DMA may hang when several channels are used in parallel OMAP3430: Not impacted, so remove the errata fix for omap3 Signed-off-by: Vikram Pandita Reviewed-by: Kamat, Nishant Acked-by: Kevin Hilman --- [Note: Respin of - http://patchwork.kernel.org/patch/32513/ Incorporated Nishant's review comment] arch/arm/plat-omap/dma.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index 34939bf..bf08634 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c @@ -946,7 +946,9 @@ void omap_start_dma(int lch) cur_lch = next_lch; } while (next_lch != -1); - } else if (cpu_class_is_omap2()) { + } else if (cpu_is_omap242x() || + (cpu_is_omap243x() && omap_type() <= OMAP2430_REV_ES1_0)) { + /* Errata: Need to write lch even if not using chaining */ dma_write(lch, CLNK_CTRL(lch)); }