From patchwork Mon Dec 14 10:30:53 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 67253 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id nBEAaGZ8031682 for ; Mon, 14 Dec 2009 10:36:17 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756615AbZLNKen (ORCPT ); Mon, 14 Dec 2009 05:34:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754992AbZLNKc3 (ORCPT ); Mon, 14 Dec 2009 05:32:29 -0500 Received: from smtp.nokia.com ([192.100.122.233]:30202 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753073AbZLNKc0 (ORCPT ); Mon, 14 Dec 2009 05:32:26 -0500 Received: from esebh106.NOE.Nokia.com (esebh106.ntc.nokia.com [172.21.138.213]) by mgw-mx06.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id nBEAVUIc028830; Mon, 14 Dec 2009 12:31:43 +0200 Received: from vaebh104.NOE.Nokia.com ([10.160.244.30]) by esebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 14 Dec 2009 12:31:36 +0200 Received: from mgw-da01.ext.nokia.com ([147.243.128.24]) by vaebh104.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Mon, 14 Dec 2009 12:31:35 +0200 Received: from localhost.localdomain (esdhcp04340.research.nokia.com [172.21.43.40]) by mgw-da01.ext.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id nBEAVF22008329; Mon, 14 Dec 2009 12:31:30 +0200 From: Felipe Balbi To: linux-kernel@vger.kernel.org Cc: Linux OMAP Mailing List , Tony Lindgren , Aaro Koskinen , David Brownell , Linux USB Mailing List , Anton Vorontsov , Grazvydas Ignotas , Madhusudhan Chikkature , Greg Kroah-Hartman , Mark Brown , Samuel Ortiz , Felipe Balbi Subject: [RFC/PATCH 3/4] rtc: twl4030: move to request_threaded_irq Date: Mon, 14 Dec 2009 12:30:53 +0200 Message-Id: <1260786654-13294-4-git-send-email-felipe.balbi@nokia.com> X-Mailer: git-send-email 1.6.6.rc0 In-Reply-To: <20091212183410.GF3092@sirena.org.uk> References: <20091212183410.GF3092@sirena.org.uk> X-OriginalArrivalTime: 14 Dec 2009 10:31:36.0264 (UTC) FILETIME=[9CED7C80:01CA7CA8] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org diff --git a/drivers/rtc/rtc-twl4030.c b/drivers/rtc/rtc-twl4030.c index 9c8c70c..46bc9c1 100644 --- a/drivers/rtc/rtc-twl4030.c +++ b/drivers/rtc/rtc-twl4030.c @@ -325,14 +325,6 @@ static irqreturn_t twl4030_rtc_interrupt(int irq, void *rtc) int res; u8 rd_reg; -#ifdef CONFIG_LOCKDEP - /* WORKAROUND for lockdep forcing IRQF_DISABLED on us, which - * we don't want and can't tolerate. Although it might be - * friendlier not to borrow this thread context... - */ - local_irq_enable(); -#endif - res = twl4030_rtc_read_u8(&rd_reg, REG_RTC_STATUS_REG); if (res) goto out; @@ -424,7 +416,7 @@ static int __devinit twl4030_rtc_probe(struct platform_device *pdev) if (ret < 0) goto out1; - ret = request_irq(irq, twl4030_rtc_interrupt, + ret = request_threaded_irq(irq, NULL, twl4030_rtc_interrupt, IRQF_TRIGGER_RISING, dev_name(&rtc->dev), rtc); if (ret < 0) {