From patchwork Tue Feb 16 08:42:27 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: omar ramirez X-Patchwork-Id: 79552 X-Patchwork-Delegate: omar.ramirez@ti.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o1G8U9tD026043 for ; Tue, 16 Feb 2010 08:30:35 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755662Ab0BPIad (ORCPT ); Tue, 16 Feb 2010 03:30:33 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:60018 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755682Ab0BPIaJ (ORCPT ); Tue, 16 Feb 2010 03:30:09 -0500 Received: from dlep34.itg.ti.com ([157.170.170.115]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id o1G8U2Li029116 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 16 Feb 2010 02:30:03 -0600 Received: from legion.dal.design.ti.com (localhost [127.0.0.1]) by dlep34.itg.ti.com (8.13.7/8.13.7) with ESMTP id o1G8U2fB023928; Tue, 16 Feb 2010 02:30:02 -0600 (CST) Received: from Matrix (matrix.am.dhcp.ti.com [128.247.75.166]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id o1G8U1Z04781; Tue, 16 Feb 2010 02:30:01 -0600 (CST) Received: by Matrix (Postfix, from userid 1003) id B370C4105FD; Tue, 16 Feb 2010 02:42:29 -0600 (CST) From: Omar Ramirez Luna To: linux-omap Cc: Ameya Palande , Hiroshi Doyu , Felipe Contreras , Nishanth Menon , Omar Ramirez Luna Subject: [PATCH 17/18] DSPBRIDGE: change critical error statements to pr_err in pmgr Date: Tue, 16 Feb 2010 02:42:27 -0600 Message-Id: <1266309748-11714-18-git-send-email-omar.ramirez@ti.com> X-Mailer: git-send-email 1.5.4.3 In-Reply-To: <1266309748-11714-17-git-send-email-omar.ramirez@ti.com> References: <1266309748-11714-1-git-send-email-omar.ramirez@ti.com> <1266309748-11714-2-git-send-email-omar.ramirez@ti.com> <1266309748-11714-3-git-send-email-omar.ramirez@ti.com> <1266309748-11714-4-git-send-email-omar.ramirez@ti.com> <1266309748-11714-5-git-send-email-omar.ramirez@ti.com> <1266309748-11714-6-git-send-email-omar.ramirez@ti.com> <1266309748-11714-7-git-send-email-omar.ramirez@ti.com> <1266309748-11714-8-git-send-email-omar.ramirez@ti.com> <1266309748-11714-9-git-send-email-omar.ramirez@ti.com> <1266309748-11714-10-git-send-email-omar.ramirez@ti.com> <1266309748-11714-11-git-send-email-omar.ramirez@ti.com> <1266309748-11714-12-git-send-email-omar.ramirez@ti.com> <1266309748-11714-13-git-send-email-omar.ramirez@ti.com> <1266309748-11714-14-git-send-email-omar.ramirez@ti.com> <1266309748-11714-15-git-send-email-omar.ramirez@ti.com> <1266309748-11714-16-git-send-email-omar.ramirez@ti.com> <1266309748-11714-17-git-send-email-omar.ramirez@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Tue, 16 Feb 2010 08:30:36 +0000 (UTC) diff --git a/drivers/dsp/bridge/pmgr/cod.c b/drivers/dsp/bridge/pmgr/cod.c index eb74fb8..541503c 100644 --- a/drivers/dsp/bridge/pmgr/cod.c +++ b/drivers/dsp/bridge/pmgr/cod.c @@ -574,10 +574,6 @@ DSP_STATUS COD_Open(struct COD_MANAGER *hMgr, IN char *pszCoffPath, DBC_Require(flags == COD_NOLOAD || flags == COD_SYMB); DBC_Require(pLib != NULL); - GT_4trace(COD_debugMask, GT_ENTER, "Entered COD_Open, hMgr: 0x%x\n\t " - "pszCoffPath: 0x%x\tflags: 0x%x\tlib: 0x%x\n", hMgr, - pszCoffPath, flags, pLib); - *pLib = NULL; lib = MEM_Calloc(sizeof(struct COD_LIBRARYOBJ), MEM_NONPAGED); @@ -592,6 +588,9 @@ DSP_STATUS COD_Open(struct COD_MANAGER *hMgr, IN char *pszCoffPath, *pLib = lib; } + if (DSP_FAILED(status)) + pr_err("%s: error status 0x%x, pszCoffPath: %s flags: 0x%x\n", + __func__, status, pszCoffPath, flags); return status; } @@ -610,10 +609,6 @@ DSP_STATUS COD_OpenBase(struct COD_MANAGER *hMgr, IN char *pszCoffPath, DBC_Require(IsValid(hMgr)); DBC_Require(pszCoffPath != NULL); - GT_2trace(COD_debugMask, GT_ENTER, - "Entered COD_OpenBase, hMgr: 0x%x\n\t" - "pszCoffPath: 0x%x\n", hMgr, pszCoffPath); - /* if we previously opened a base image, close it now */ if (hMgr->baseLib) { if (hMgr->fLoaded) { @@ -631,6 +626,9 @@ DSP_STATUS COD_OpenBase(struct COD_MANAGER *hMgr, IN char *pszCoffPath, hMgr->szZLFile[COD_MAXPATHLENGTH - 1] = '\0'; } + if (DSP_FAILED(status)) + pr_err("%s: error status 0x%x pszCoffPath: %s\n", __func__, + status, pszCoffPath); return status; } diff --git a/drivers/dsp/bridge/pmgr/dev.c b/drivers/dsp/bridge/pmgr/dev.c index 8ee6d69..e4450bc 100644 --- a/drivers/dsp/bridge/pmgr/dev.c +++ b/drivers/dsp/bridge/pmgr/dev.c @@ -215,9 +215,8 @@ DSP_STATUS DEV_CreateDevice(OUT struct DEV_OBJECT **phDevObject, } else { ioMgrAttrs.dwSMBase = 0; ioMgrAttrs.uSMLength = 0; - GT_0trace(debugMask, GT_7CLASS, - "**There is no memory reserved for " - "shared structures**\n"); + pr_err("%s: No memory reserved for shared structures\n", + __func__); } status = CHNL_Create(&pDevObject->hChnlMgr, pDevObject, &mgrAttrs); diff --git a/drivers/dsp/bridge/pmgr/dmm.c b/drivers/dsp/bridge/pmgr/dmm.c index ebecc8b..2840674 100644 --- a/drivers/dsp/bridge/pmgr/dmm.c +++ b/drivers/dsp/bridge/pmgr/dmm.c @@ -120,10 +120,10 @@ DSP_STATUS DMM_CreateTables(struct DMM_OBJECT *hDmmMgr, u32 addr, u32 size) pVirtualMappingTable[0].RegionSize = TableSize; } SYNC_LeaveCS(pDmmObj->hDmmLock); - } else - GT_0trace(DMM_debugMask, GT_7CLASS, - "DMM_CreateTables: DMM_DeleteTables" - "Failure\n"); + } + + if (DSP_FAILED(status)) + pr_err("%s: failure, status 0x%x\n", __func__, status); return status; }