From patchwork Tue Mar 23 21:25:36 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Contreras X-Patchwork-Id: 87768 X-Patchwork-Delegate: omar.ramirez@ti.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o2NLQBUw018061 for ; Tue, 23 Mar 2010 21:26:13 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753467Ab0CWV0M (ORCPT ); Tue, 23 Mar 2010 17:26:12 -0400 Received: from mail-bw0-f209.google.com ([209.85.218.209]:46268 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001Ab0CWV0L (ORCPT ); Tue, 23 Mar 2010 17:26:11 -0400 Received: by mail-bw0-f209.google.com with SMTP id 1so2292192bwz.21 for ; Tue, 23 Mar 2010 14:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=SgMbpxhvToKVbxUUxRFA5mGmkRjgHDyILITDVkfWZ68=; b=wh+SwhCuuZmuwUoCpdyWV5SPWRKtXmTuS6VONJDnjathGMxDCQoUB2ZKwzu7/sI+kD JY1y7zH7Xp1Dp2MZ7SGrhD7jw54yEvVqe5Q84Vm6h/bANIgTXlPtA+jKfgc90nlCNH01 GYbh/r7+L0a/J/UkMGD9sR6by3zCCieNraAZg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=RZGOwhJihCK9VWf1ppcRu/HLx2vDI7QWEq645o2gP/gi4ZjQnECBiSlzXRi0GhOOoC vz5L+CeWDsq0E/pCdjSHJ3SFZKsKaOm+w0/DTJcHeTZ2OVrtgaE10M4Dd5WMRIJmHWn9 bI9gr/Zzzkc0uGazj6xagmsQYSh8TBxAtRdQY= Received: by 10.204.21.197 with SMTP id k5mr5880095bkb.28.1269379569578; Tue, 23 Mar 2010 14:26:09 -0700 (PDT) Received: from localhost (a91-153-253-80.elisa-laajakaista.fi [91.153.253.80]) by mx.google.com with ESMTPS id 15sm2981856bwz.0.2010.03.23.14.26.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 23 Mar 2010 14:26:08 -0700 (PDT) From: Felipe Contreras To: linux-omap Cc: Ameya Palande , Omar Ramirez Luna , Felipe Contreras Subject: [PATCH 04/10] dsp-bridge: deh: improve logging stuff Date: Tue, 23 Mar 2010 23:25:36 +0200 Message-Id: <1269379542-11892-5-git-send-email-felipe.contreras@gmail.com> X-Mailer: git-send-email 1.7.0.3 In-Reply-To: <1269379542-11892-1-git-send-email-felipe.contreras@gmail.com> References: <1269379542-11892-1-git-send-email-felipe.contreras@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Tue, 23 Mar 2010 21:26:13 +0000 (UTC) diff --git a/drivers/dsp/bridge/wmd/ue_deh.c b/drivers/dsp/bridge/wmd/ue_deh.c index fae036f..0c29442 100644 --- a/drivers/dsp/bridge/wmd/ue_deh.c +++ b/drivers/dsp/bridge/wmd/ue_deh.c @@ -182,9 +182,7 @@ void bridge_deh_notify(struct deh_mgr *hdeh_mgr, u32 ulEventMask, u32 dwErrInfo) &resources); if (MEM_IS_VALID_HANDLE(deh_mgr_obj, SIGNATURE)) { - printk(KERN_INFO - "bridge_deh_notify: ********** DEVICE EXCEPTION " - "**********\n"); + dev_info(bridge, "%s: device exception\n", __func__); dev_context = (struct wmd_dev_context *)deh_mgr_obj->hwmd_context; @@ -196,9 +194,8 @@ void bridge_deh_notify(struct deh_mgr *hdeh_mgr, u32 ulEventMask, u32 dwErrInfo) deh_mgr_obj->err_info.dw_val2 = 0L; deh_mgr_obj->err_info.dw_val3 = 0L; deh_mgr_obj->err_info.dw_val1 = dwErrInfo; - printk(KERN_ERR - "bridge_deh_notify: DSP_SYSERROR, err_info " - "= 0x%x\n", dwErrInfo); + dev_err(bridge, "%s: %s, err_info = 0x%x\n", + __func__, "DSP_SYSERROR", dwErrInfo); break; case DSP_MMUFAULT: /* @@ -206,18 +203,13 @@ void bridge_deh_notify(struct deh_mgr *hdeh_mgr, u32 ulEventMask, u32 dwErrInfo) * structure. */ deh_mgr_obj->err_info.dw_err_mask = DSP_MMUFAULT; - printk(KERN_INFO "bridge_deh_notify: DSP_MMUFAULT," - "err_info = 0x%x\n", dwErrInfo); - printk(KERN_INFO - "bridge_deh_notify: DSP_MMUFAULT, High " - "Address = 0x%x\n", - (unsigned int)deh_mgr_obj->err_info.dw_val1); - printk(KERN_INFO "bridge_deh_notify: DSP_MMUFAULT, Low " - "Address = 0x%x\n", - (unsigned int)deh_mgr_obj->err_info.dw_val2); - printk(KERN_INFO - "bridge_deh_notify: DSP_MMUFAULT, fault " - "address = 0x%x\n", (unsigned int)fault_addr); + dev_info(bridge, "%s: %s, err_info = 0x%x\n", + __func__, "DSP_MMUFAULT", dwErrInfo); + dev_info(bridge, "%s: %s, high=0x%x, low=0x%x, fault=0x%x\n", + __func__, "DSP_MMUFAULT", + (unsigned int) deh_mgr->err_info.dw_val1, + (unsigned int) deh_mgr->err_info.dw_val2, + (unsigned int) fault_addr); dummy_va_addr = (u32) mem_calloc(sizeof(char) * 0x1000, MEM_PAGED); mem_physical = @@ -257,9 +249,8 @@ void bridge_deh_notify(struct deh_mgr *hdeh_mgr, u32 ulEventMask, u32 dwErrInfo) deh_mgr_obj->err_info.dw_val2 = 0L; deh_mgr_obj->err_info.dw_val3 = 0L; deh_mgr_obj->err_info.dw_val1 = dwErrInfo; - printk(KERN_ERR - "bridge_deh_notify: DSP_PWRERROR, err_info " - "= 0x%x\n", dwErrInfo); + dev_err(bridge, "%s: %s, err_info = 0x%x\n", + __func__, "DSP_PWRERROR", dwErrInfo); break; #endif /* CONFIG_BRIDGE_NTFY_PWRERR */ default: