From patchwork Wed Apr 7 16:03:54 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 91060 X-Patchwork-Delegate: tony@atomide.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o37G5HI6005510 for ; Wed, 7 Apr 2010 16:05:17 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932695Ab0DGQFQ (ORCPT ); Wed, 7 Apr 2010 12:05:16 -0400 Received: from smtp.nokia.com ([192.100.122.230]:58469 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932570Ab0DGQFO (ORCPT ); Wed, 7 Apr 2010 12:05:14 -0400 Received: from vaebh106.NOE.Nokia.com (vaebh106.europe.nokia.com [10.160.244.32]) by mgw-mx03.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id o37G58ee004996 for ; Wed, 7 Apr 2010 19:05:12 +0300 Received: from vaebh104.NOE.Nokia.com ([10.160.244.30]) by vaebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 7 Apr 2010 19:04:44 +0300 Received: from mgw-da02.ext.nokia.com ([147.243.128.26]) by vaebh104.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Wed, 7 Apr 2010 19:04:43 +0300 Received: from localhost.localdomain (esdhcp04088.research.nokia.com [172.21.40.88]) by mgw-da02.ext.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id o37G4YMl015130; Wed, 7 Apr 2010 19:04:39 +0300 From: felipe.balbi@nokia.com To: Linux OMAP Mailing List Cc: Felipe Balbi Subject: [RFC PATCH 03/37] cbus: checkpatch.pl fix on cbus.c Date: Wed, 7 Apr 2010 19:03:54 +0300 Message-Id: <1270656268-7034-4-git-send-email-felipe.balbi@nokia.com> X-Mailer: git-send-email 1.7.0.rc0.33.g7c3932 In-Reply-To: <1270656268-7034-1-git-send-email-felipe.balbi@nokia.com> References: <1270656268-7034-1-git-send-email-felipe.balbi@nokia.com> X-OriginalArrivalTime: 07 Apr 2010 16:04:43.0842 (UTC) FILETIME=[098B5A20:01CAD66C] X-Nokia-AV: Clean Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Wed, 07 Apr 2010 16:05:18 +0000 (UTC) diff --git a/drivers/cbus/cbus.c b/drivers/cbus/cbus.c index f454e77..e1be8c7 100644 --- a/drivers/cbus/cbus.c +++ b/drivers/cbus/cbus.c @@ -136,7 +136,7 @@ static u8 _cbus_receive_bit(struct cbus_host *host) return ret; } -#define cbus_send_bit(host, base, bit, set_to_input) _cbus_send_bit(host, bit, set_to_input) +#define cbus_send_bit(h, b, bit, i) _cbus_send_bit(h, bit, i) #define cbus_receive_bit(host, base) _cbus_receive_bit(host) #endif @@ -232,7 +232,7 @@ static int __init cbus_bus_probe(struct platform_device *pdev) struct cbus_host_platform_data *pdata = pdev->dev.platform_data; int ret; - chost = kzalloc(sizeof (*chost), GFP_KERNEL); + chost = kzalloc(sizeof(*chost), GFP_KERNEL); if (chost == NULL) return -ENOMEM; @@ -242,13 +242,16 @@ static int __init cbus_bus_probe(struct platform_device *pdev) chost->dat_gpio = pdata->dat_gpio; chost->sel_gpio = pdata->sel_gpio; - if ((ret = gpio_request(chost->clk_gpio, "CBUS clk")) < 0) + ret = gpio_request(chost->clk_gpio, "CBUS clk"); + if (ret < 0) goto exit1; - if ((ret = gpio_request(chost->dat_gpio, "CBUS data")) < 0) + ret = gpio_request(chost->dat_gpio, "CBUS data"); + if (ret < 0) goto exit2; - if ((ret = gpio_request(chost->sel_gpio, "CBUS sel")) < 0) + ret = gpio_request(chost->sel_gpio, "CBUS sel"); + if (ret < 0) goto exit3; gpio_direction_output(chost->clk_gpio, 0);