From patchwork Mon May 24 14:20:27 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Scott Ellis <scott@jumpnowtek.com>
X-Patchwork-Id: 101889
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o4OFnnFn013433
	for <patchwork-omap@patchwork.kernel.org>;
	Mon, 24 May 2010 15:49:50 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753537Ab0EXPtr (ORCPT
	<rfc822;patchwork-omap@patchwork.kernel.org>);
	Mon, 24 May 2010 11:49:47 -0400
Received: from pan.gwi.net ([207.5.128.165]:4286 "EHLO pan.gwi.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752208Ab0EXPtq (ORCPT <rfc822;linux-omap@vger.kernel.org>);
	Mon, 24 May 2010 11:49:46 -0400
Received: from [192.168.10.4] (66-63-88-74.static.suscom-maine.net
	[66.63.88.74])
	by pan.gwi.net (8.13.1/8.13.1) with ESMTP id o4OEKStr068728;
	Mon, 24 May 2010 10:20:28 -0400 (EDT)
	(envelope-from scott@jumpnowtek.com)
Subject: Re: [PATCHv3 1/6] SPI omap2_mcspi.c: Check params before
	dereference or use
From: Scott Ellis <scott@jumpnowtek.com>
To: spi-devel-general@lists.sourceforge.net
Cc: Grant Likely <grant.likely@secretlab.ca>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tony Lindgren <tony@atomide.com>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Aaro Koskinen <Aaro.Koskinen@nokia.com>,
	Roman Tereshonkov <roman.tereshonkov@nokia.com>,
	linux-omap@vger.kernel.org
In-Reply-To: <AANLkTikCydr_Nj446sySru774pY2jXLKNUNVfW3LSK9R@mail.gmail.com>
References: <1268406713.14445.50.camel@quad>
	<AANLkTikCydr_Nj446sySru774pY2jXLKNUNVfW3LSK9R@mail.gmail.com>
Date: Mon, 24 May 2010 10:20:27 -0400
Message-ID: <1274710827.2888.9.camel@quad>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3 
Sender: linux-omap-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-omap.vger.kernel.org>
X-Mailing-List: linux-omap@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]);
	Mon, 24 May 2010 15:49:50 +0000 (UTC)


diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
index e0de0d0..0b35468 100644
--- a/drivers/spi/omap2_mcspi.c
+++ b/drivers/spi/omap2_mcspi.c
@@ -755,7 +755,6 @@ static void omap2_mcspi_cleanup(struct spi_device
*spi)
 	struct omap2_mcspi_cs	*cs;
 
 	mcspi = spi_master_get_devdata(spi->master);
-	mcspi_dma = &mcspi->dma_channels[spi->chip_select];
 
 	if (spi->controller_state) {