From patchwork Fri Jun 25 21:46:40 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 108150 X-Patchwork-Delegate: khilman@deeprootsystems.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o5PLkreb016683 for ; Fri, 25 Jun 2010 21:46:53 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932290Ab0FYVqw (ORCPT ); Fri, 25 Jun 2010 17:46:52 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:53133 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756582Ab0FYVqq (ORCPT ); Fri, 25 Jun 2010 17:46:46 -0400 Received: from dlep35.itg.ti.com ([157.170.170.118]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id o5PLkjMt030411 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 25 Jun 2010 16:46:45 -0500 Received: from legion.dal.design.ti.com (localhost [127.0.0.1]) by dlep35.itg.ti.com (8.13.7/8.13.7) with ESMTP id o5PLkgGa020322; Fri, 25 Jun 2010 16:46:42 -0500 (CDT) Received: from senorita (senorita.am.dhcp.ti.com [128.247.74.250]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id o5PLkgP15908; Fri, 25 Jun 2010 16:46:42 -0500 (CDT) Received: by senorita (Postfix, from userid 1000) id 7C820C1A5; Fri, 25 Jun 2010 16:46:41 -0500 (CDT) From: Nishanth Menon To: linux-omap Cc: Nishanth Menon , Kevin Hilman , Thara Gopinath Subject: [PM-SR] [PATCH 7/7] omap3: sr: device: fail sr_dev_init should return error Date: Fri, 25 Jun 2010 16:46:40 -0500 Message-Id: <1277502400-9915-8-git-send-email-nm@ti.com> X-Mailer: git-send-email 1.6.3.3 In-Reply-To: <1277502400-9915-1-git-send-email-nm@ti.com> References: <1277502400-9915-1-git-send-email-nm@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Fri, 25 Jun 2010 21:46:53 +0000 (UTC) diff --git a/arch/arm/mach-omap2/sr_device.c b/arch/arm/mach-omap2/sr_device.c index 81d2532..945ff45 100644 --- a/arch/arm/mach-omap2/sr_device.c +++ b/arch/arm/mach-omap2/sr_device.c @@ -163,7 +163,7 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user) __func__, i + 1); i++; kfree(sr_data); - return 0; + return -ENODATA; } sr_set_nvalues(sr_dev_data, sr_data); od = omap_device_build(name, i, oh, sr_data, sizeof(*sr_data), @@ -173,6 +173,7 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user) pr_warning("%s: Could not build omap_device for %s: %s.\n\n", __func__, name, oh->name); kfree(sr_data); + return PTR_ERR(od); } i++; return 0;