From patchwork Thu Jul 1 13:40:01 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Afzal Mohammed X-Patchwork-Id: 109114 X-Patchwork-Delegate: tomi.valkeinen@nokia.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o61DfnJQ026312 for ; Thu, 1 Jul 2010 13:41:49 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754481Ab0GANkw (ORCPT ); Thu, 1 Jul 2010 09:40:52 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:41466 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751941Ab0GANkv (ORCPT ); Thu, 1 Jul 2010 09:40:51 -0400 Received: by pvc7 with SMTP id 7so817117pvc.19 for ; Thu, 01 Jul 2010 06:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=FgOfzoG28hy/6dVYvwPcC0SNiESlhgQ3db8kK/YaREA=; b=J1kciFIs4DU38ILUS8261nyxFEcv6nFOKRWK1vegyYkDHGDL1fxfd+LOfRodZy3/du HLbBrl5EL3FhPQC7eYCziCYleEhNWtHGS3eR7WseegjLqebUKRCP3TOgivWypln/z7Bi SE5jTiG2ErFJAZBpxOT0FE4Xhalt7ofcNEgBw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=GKhpE9Xi13rk7yqAGHtrNwOEIv/Q0iihRYmSfKM4Iq+K4Ykfa7GMDA4tjbETpWKVFT 29W2iPAWz5pNrZPGoD5WkWyIgiMEmRppDwB24DfNpYrQp+YbkQg2rFIIzyBAntM6dvwI Slqf/2XQ3hZ4qmFiqv6SzsM9sxBgxB+Ifcxb4= Received: by 10.115.38.22 with SMTP id q22mr12000642waj.41.1277991650212; Thu, 01 Jul 2010 06:40:50 -0700 (PDT) Received: from localhost.localdomain ([122.167.45.162]) by mx.google.com with ESMTPS id n32sm87253190wag.7.2010.07.01.06.40.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 01 Jul 2010 06:40:49 -0700 (PDT) From: Afzal Mohammed To: tomi.valkeinen@nokia.com Cc: ville.syrjala@nokia.com, tj@kernel.org, lazfamam@gmail.com, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] OMAP:DSS2:OMAPFB: Fix probe error path Date: Thu, 1 Jul 2010 19:10:01 +0530 Message-Id: <1277991601-16528-2-git-send-email-lazfamam@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1277991601-16528-1-git-send-email-lazfamam@gmail.com> References: <1277991601-16528-1-git-send-email-lazfamam@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Thu, 01 Jul 2010 13:41:49 +0000 (UTC) diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c index 4b4506d..710e117 100644 --- a/drivers/video/omap2/omapfb/omapfb-main.c +++ b/drivers/video/omap2/omapfb/omapfb-main.c @@ -1928,13 +1928,6 @@ static int omapfb_create_framebuffers(struct omapfb2_device *fbdev) } } - DBG("create sysfs for fbs\n"); - r = omapfb_create_sysfs(fbdev); - if (r) { - dev_err(fbdev->dev, "failed to create sysfs entries\n"); - return r; - } - /* Enable fb0 */ if (fbdev->num_fbs > 0) { struct omapfb_info *ofbi = FB2OFB(fbdev->fbs[0]); @@ -2220,6 +2213,13 @@ static int omapfb_probe(struct platform_device *pdev) } } + DBG("create sysfs for fbs\n"); + r = omapfb_create_sysfs(fbdev); + if (r) { + dev_err(fbdev->dev, "failed to create sysfs entries\n"); + goto cleanup; + } + return 0; cleanup: