From patchwork Wed Jul 28 14:45:27 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ramos Falcon, Ernesto" X-Patchwork-Id: 114789 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o6SEhrmW012087 for ; Wed, 28 Jul 2010 14:43:53 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754857Ab0G1Okv (ORCPT ); Wed, 28 Jul 2010 10:40:51 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:35251 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753424Ab0G1Oku (ORCPT ); Wed, 28 Jul 2010 10:40:50 -0400 Received: from dlep33.itg.ti.com ([157.170.170.112]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id o6SEekWC031469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 28 Jul 2010 09:40:46 -0500 Received: from emcc1.sasken-mty.naucm.ext.ti.com (localhost [127.0.0.1]) by dlep33.itg.ti.com (8.13.7/8.13.7) with ESMTP id o6SEeiVI006013; Wed, 28 Jul 2010 09:40:45 -0500 (CDT) Received: from localhost.localdomain (x0076199-desktop.sasken-mty.naucm.ext.ti.com [10.87.230.107]) by emcc1.sasken-mty.naucm.ext.ti.com (8.13.8+Sun/8.13.8) with ESMTP id o6SEehVL016736; Wed, 28 Jul 2010 09:40:44 -0500 (CDT) From: Ernesto Ramos To: gregkh@suse.de Cc: omar.ramirez@ti.com, ohad@wizery.com, ameya.palande@nokia.com, felipe.contreras@nokia.com, fernando.lugo@ti.com, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com, nm@ti.com, linux-omap@vger.kernel.org, Ernesto Ramos Subject: [PATCH 04/10] staging:ti dspbridge: remove DSP_SUCCEEDED macro from services Date: Wed, 28 Jul 2010 09:45:27 -0500 Message-Id: <1280328333-31336-5-git-send-email-ernesto@ti.com> X-Mailer: git-send-email 1.5.4.5 In-Reply-To: <1280328333-31336-4-git-send-email-ernesto@ti.com> References: <1280328333-31336-1-git-send-email-ernesto@ti.com> <1280328333-31336-2-git-send-email-ernesto@ti.com> <1280328333-31336-3-git-send-email-ernesto@ti.com> <1280328333-31336-4-git-send-email-ernesto@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Wed, 28 Jul 2010 14:43:53 +0000 (UTC) diff --git a/drivers/staging/tidspbridge/services/cfg.c b/drivers/staging/tidspbridge/services/cfg.c index 4ab3cd7..c3f33f6 100644 --- a/drivers/staging/tidspbridge/services/cfg.c +++ b/drivers/staging/tidspbridge/services/cfg.c @@ -62,7 +62,7 @@ int cfg_get_auto_start(struct cfg_devnode *dev_node_obj, status = -EFAULT; if (!auto_start || !drv_datap) status = -EFAULT; - if (DSP_SUCCEEDED(status)) + if (!status) *auto_start = (drv_datap->base_img) ? 1 : 0; DBC_ENSURE((status == 0 && @@ -93,7 +93,7 @@ int cfg_get_dev_object(struct cfg_devnode *dev_node_obj, status = -EFAULT; dw_buf_size = sizeof(value); - if (DSP_SUCCEEDED(status)) { + if (!status) { /* check the device string and then store dev object */ if (! @@ -127,7 +127,7 @@ int cfg_get_exec_file(struct cfg_devnode *dev_node_obj, u32 buf_size, if (strlen(drv_datap->base_img) > buf_size) status = -EINVAL; - if (DSP_SUCCEEDED(status) && drv_datap->base_img) + if (!status && drv_datap->base_img) strcpy(str_exec_file, drv_datap->base_img); if (DSP_FAILED(status)) @@ -178,7 +178,7 @@ int cfg_get_object(u32 *value, u8 dw_type) *value = 0; pr_err("%s: Failed, status 0x%x\n", __func__, status); } - DBC_ENSURE((DSP_SUCCEEDED(status) && *value != 0) || + DBC_ENSURE((!status && *value != 0) || (DSP_FAILED(status) && *value == 0)); return status; } @@ -211,7 +211,7 @@ int cfg_set_dev_object(struct cfg_devnode *dev_node_obj, u32 value) if (!dev_node_obj) status = -EFAULT; - if (DSP_SUCCEEDED(status)) { + if (!status) { /* Store the Bridge device object in the Registry */ if (!(strcmp((char *)dev_node_obj, "TIOMAP1510")))