From patchwork Thu Aug 5 22:24:06 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 117502 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o75MOh7c026723 for ; Thu, 5 Aug 2010 22:24:43 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760775Ab0HEWYX (ORCPT ); Thu, 5 Aug 2010 18:24:23 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:57509 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760819Ab0HEWYT (ORCPT ); Thu, 5 Aug 2010 18:24:19 -0400 Received: from dlep33.itg.ti.com ([157.170.170.112]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id o75MOH5C032454 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 5 Aug 2010 17:24:17 -0500 Received: from legion.dal.design.ti.com (localhost [127.0.0.1]) by dlep33.itg.ti.com (8.13.7/8.13.7) with ESMTP id o75MOESq007446; Thu, 5 Aug 2010 17:24:14 -0500 (CDT) Received: from senorita (senorita.am.dhcp.ti.com [128.247.74.250]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id o75MOEf27255; Thu, 5 Aug 2010 17:24:14 -0500 (CDT) Received: by senorita (Postfix, from userid 1000) id 0C53DC264; Thu, 5 Aug 2010 17:24:13 -0500 (CDT) From: Nishanth Menon To: linux-omap Cc: Nishanth Menon , Kevin Hilman , Thara Gopinath Subject: [PM-SR][PATCH 06/12] omap3: sr: device: fail sr_dev_init should return error Date: Thu, 5 Aug 2010 17:24:06 -0500 Message-Id: <1281047052-21346-7-git-send-email-nm@ti.com> X-Mailer: git-send-email 1.6.3.3 In-Reply-To: <1281047052-21346-1-git-send-email-nm@ti.com> References: <1281047052-21346-1-git-send-email-nm@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Thu, 05 Aug 2010 22:24:43 +0000 (UTC) diff --git a/arch/arm/mach-omap2/sr_device.c b/arch/arm/mach-omap2/sr_device.c index 6f70da6..8fb60d8 100644 --- a/arch/arm/mach-omap2/sr_device.c +++ b/arch/arm/mach-omap2/sr_device.c @@ -162,7 +162,7 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user) __func__, i + 1); i++; kfree(sr_data); - return 0; + return -ENODATA; } sr_set_nvalues(sr_dev_data, sr_data); od = omap_device_build(name, i, oh, sr_data, sizeof(*sr_data), @@ -172,6 +172,7 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user) pr_warning("%s: Could not build omap_device for %s: %s.\n\n", __func__, name, oh->name); kfree(sr_data); + return PTR_ERR(od); } i++; return 0;