From patchwork Wed Nov 24 07:20:48 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: axel lin <axel.lin@gmail.com>
X-Patchwork-Id: 351861
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oAO7GDrX001785
	for <patchwork-omap@patchwork.kernel.org>;
	Wed, 24 Nov 2010 07:16:14 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750897Ab0KXHPn (ORCPT
	<rfc822;patchwork-omap@patchwork.kernel.org>);
	Wed, 24 Nov 2010 02:15:43 -0500
Received: from mail-gy0-f174.google.com ([209.85.160.174]:40532 "EHLO
	mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750707Ab0KXHPn (ORCPT
	<rfc822; linux-omap@vger.kernel.org>); Wed, 24 Nov 2010 02:15:43 -0500
Received: by gyb11 with SMTP id 11so2579540gyb.19
	for <multiple recipients>; Tue, 23 Nov 2010 23:15:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:subject:from:to:cc
	:content-type:date:message-id:mime-version:x-mailer
	:content-transfer-encoding;
	bh=CaNRtct44BYyuICTRoa8mQihLEJFi7M8gPZX8rrvu6I=;
	b=OHF6t5THDlmZ8TuHqO/AjtGMxrvt8xZtvK7dW2WcbN0aggsvDlRkKv4EBIwrQdpvhA
	ncXLEW7hMo+2Jztc+YwrBqaiFArup67Yo5oQXFYtVR8p3YNuwBBPKyKNW+SvchenKQ5W
	y28ZQ2l+HyIfMwr7M2wIRI3R/5GzZoCccHsTI=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=subject:from:to:cc:content-type:date:message-id:mime-version
	:x-mailer:content-transfer-encoding;
	b=ekux9vjb4Cw8A5oiU8qSBPxYYbFs1D0uHU13gsCHqP26zNIQrtHPmT8F7jwpHwOFPT
	P5Iocqkphky2Tybe8deG8eUFze5zhKWl1TOJlob0zb/FB4SMIlLsSdfqFcWDub163O3m
	KUYjvXCAsv03I3oTJ7q4ADDbQBHEvBeg/m4zg=
Received: by 10.150.11.8 with SMTP id 8mr412494ybk.87.1290582942352;
	Tue, 23 Nov 2010 23:15:42 -0800 (PST)
Received: from [192.168.100.50] (60-251-136-127.HINET-IP.hinet.net
	[60.251.136.127])
	by mx.google.com with ESMTPS id t4sm895579ybe.13.2010.11.23.23.15.38
	(version=SSLv3 cipher=RC4-MD5);
	Tue, 23 Nov 2010 23:15:41 -0800 (PST)
Subject: [PATCH 1/2] ASoC: Return proper error for omap3pandora_soc_init
From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Grazvydas Ignotas <notasas@gmail.com>, Jarkko Nikula <jhnikula@gmail.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	linux-omap@vger.kernel.org
Date: Wed, 24 Nov 2010 15:20:48 +0800
Message-Id: <1290583248.20639.1.camel@mola>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 
Sender: linux-omap-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-omap.vger.kernel.org>
X-Mailing-List: linux-omap@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]);
	Wed, 24 Nov 2010 07:16:14 +0000 (UTC)


diff --git a/sound/soc/omap/omap3pandora.c b/sound/soc/omap/omap3pandora.c
index bff9864..8047c52 100644
--- a/sound/soc/omap/omap3pandora.c
+++ b/sound/soc/omap/omap3pandora.c
@@ -307,6 +307,7 @@ static int __init omap3pandora_soc_init(void)
 		pr_err(PREFIX "Failed to get DAC regulator from %s: %ld\n",
 			dev_name(&omap3pandora_snd_device->dev),
 			PTR_ERR(omap3pandora_dac_reg));
+		ret = PTR_ERR(omap3pandora_dac_reg);
 		goto fail3;
 	}