From patchwork Fri Apr 1 04:52:44 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishanth Menon X-Patchwork-Id: 680471 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p314rQ5D021491 for ; Fri, 1 Apr 2011 04:53:26 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752031Ab1DAExZ (ORCPT ); Fri, 1 Apr 2011 00:53:25 -0400 Received: from na3sys009aog104.obsmtp.com ([74.125.149.73]:45169 "EHLO na3sys009aog104.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590Ab1DAExY (ORCPT ); Fri, 1 Apr 2011 00:53:24 -0400 Received: from source ([209.85.161.169]) (using TLSv1) by na3sys009aob104.postini.com ([74.125.148.12]) with SMTP ID DSNKTZVaQ8wu7irlUJpPz9dh5o97Y+6cDtGf@postini.com; Thu, 31 Mar 2011 21:53:24 PDT Received: by gxk23 with SMTP id 23so1637514gxk.14 for ; Thu, 31 Mar 2011 21:53:23 -0700 (PDT) Received: by 10.151.45.11 with SMTP id x11mr3696606ybj.401.1301633603164; Thu, 31 Mar 2011 21:53:23 -0700 (PDT) Received: from localhost (dragon.ti.com [192.94.94.33]) by mx.google.com with ESMTPS id o2sm196468ybn.6.2011.03.31.21.53.18 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 31 Mar 2011 21:53:22 -0700 (PDT) From: Nishanth Menon To: linux-omap Cc: Liam Girdwood , Mark Brown , Samuel Ortiz , Saquib , Nishanth Menon Subject: [PATCH 3/5] regulator: twl: fix twl6030 regulator is_enabled Date: Fri, 1 Apr 2011 10:22:44 +0530 Message-Id: <1301633566-5212-4-git-send-email-nm@ti.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1301633566-5212-1-git-send-email-nm@ti.com> References: <1301633566-5212-1-git-send-email-nm@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 01 Apr 2011 04:53:26 +0000 (UTC) diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c index 2e88865..11d2e08 100644 --- a/drivers/regulator/twl-regulator.c +++ b/drivers/regulator/twl-regulator.c @@ -80,6 +80,10 @@ struct twlreg_info { #define TWL6030_CFG_STATE_OFF 0x00 #define TWL6030_CFG_STATE_ON 0x01 #define TWL6030_CFG_STATE_GRP_SHIFT 5 +#define TWL6030_CFG_STATE_APP_SHIFT 2 +#define TWL6030_CFG_STATE_APP_MASK (0x03 << TWL6030_CFG_STATE_APP_SHIFT) +#define TWL6030_CFG_STATE_APP(v) (((v) & TWL6030_CFG_STATE_APP_MASK) >>\ + TWL6030_CFG_STATE_APP_SHIFT) static inline int twlreg_read(struct twlreg_info *info, unsigned slave_subgp, unsigned offset) @@ -123,18 +127,31 @@ static int twlreg_grp(struct regulator_dev *rdev) #define P2_GRP_6030 BIT(1) /* "peripherals" */ #define P1_GRP_6030 BIT(0) /* CPU/Linux */ -static int twlreg_is_enabled(struct regulator_dev *rdev) +static int twl4030reg_is_enabled(struct regulator_dev *rdev) { int state = twlreg_grp(rdev); if (state < 0) return state; - if (twl_class_is_4030()) - state &= P1_GRP_4030; - else - state &= P1_GRP_6030; - return state; + return state & P1_GRP_4030; +} + +static int twl6030reg_is_enabled(struct regulator_dev *rdev) +{ + struct twlreg_info *info = rdev_get_drvdata(rdev); + int grp, val; + + grp = twlreg_read(info, TWL_MODULE_PM_RECEIVER, VREG_GRP); + if (grp < 0) + return grp; + + grp &= P1_GRP_6030; + + val = twlreg_read(info, TWL_MODULE_PM_RECEIVER, VREG_STATE); + val = TWL6030_CFG_STATE_APP(val); + + return grp && (val == TWL6030_CFG_STATE_ON); } static int twlreg_enable(struct regulator_dev *rdev) @@ -406,7 +423,7 @@ static struct regulator_ops twl4030ldo_ops = { .enable = twlreg_enable, .disable = twlreg_disable, - .is_enabled = twlreg_is_enabled, + .is_enabled = twl4030reg_is_enabled, .set_mode = twlreg_set_mode, @@ -464,7 +481,7 @@ static struct regulator_ops twl6030ldo_ops = { .enable = twlreg_enable, .disable = twlreg_disable, - .is_enabled = twlreg_is_enabled, + .is_enabled = twl6030reg_is_enabled, .set_mode = twlreg_set_mode, @@ -490,14 +507,28 @@ static int twlfixed_get_voltage(struct regulator_dev *rdev) return info->min_mV * 1000; } -static struct regulator_ops twlfixed_ops = { +static struct regulator_ops twl4030fixed_ops = { + .list_voltage = twlfixed_list_voltage, + + .get_voltage = twlfixed_get_voltage, + + .enable = twlreg_enable, + .disable = twlreg_disable, + .is_enabled = twl4030reg_is_enabled, + + .set_mode = twlreg_set_mode, + + .get_status = twlreg_get_status, +}; + +static struct regulator_ops twl6030fixed_ops = { .list_voltage = twlfixed_list_voltage, .get_voltage = twlfixed_get_voltage, .enable = twlreg_enable, .disable = twlreg_disable, - .is_enabled = twlreg_is_enabled, + .is_enabled = twl6030reg_is_enabled, .set_mode = twlreg_set_mode, @@ -507,7 +538,7 @@ static struct regulator_ops twlfixed_ops = { static struct regulator_ops twl6030_fixed_resource = { .enable = twlreg_enable, .disable = twlreg_disable, - .is_enabled = twlreg_is_enabled, + .is_enabled = twl6030reg_is_enabled, .get_status = twlreg_get_status, }; @@ -516,10 +547,10 @@ static struct regulator_ops twl6030_fixed_resource = { #define TWL4030_FIXED_LDO(label, offset, mVolts, num, turnon_delay, \ remap_conf) \ TWL_FIXED_LDO(label, offset, mVolts, num, turnon_delay, \ - remap_conf, TWL4030) + remap_conf, TWL4030, twl4030fixed_ops) #define TWL6030_FIXED_LDO(label, offset, mVolts, num, turnon_delay) \ TWL_FIXED_LDO(label, offset, mVolts, num, turnon_delay, \ - 0x0, TWL6030) + 0x0, TWL6030, twl6030fixed_ops) #define TWL4030_ADJUSTABLE_LDO(label, offset, num, turnon_delay, remap_conf) { \ .base = offset, \ @@ -555,7 +586,7 @@ static struct regulator_ops twl6030_fixed_resource = { #define TWL_FIXED_LDO(label, offset, mVolts, num, turnon_delay, remap_conf, \ - family) { \ + family, operations) { \ .base = offset, \ .id = num, \ .min_mV = mVolts, \ @@ -565,7 +596,7 @@ static struct regulator_ops twl6030_fixed_resource = { .name = #label, \ .id = family##_REG_##label, \ .n_voltages = 1, \ - .ops = &twlfixed_ops, \ + .ops = &operations, \ .type = REGULATOR_VOLTAGE, \ .owner = THIS_MODULE, \ }, \