From patchwork Thu Apr 14 07:31:43 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Kilb X-Patchwork-Id: 706411 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p3E7WDnR022056 for ; Thu, 14 Apr 2011 07:32:13 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757537Ab1DNHb5 (ORCPT ); Thu, 14 Apr 2011 03:31:57 -0400 Received: from mail.x-arc.co.uk ([217.6.246.34]:42553 "EHLO root.phytec.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753447Ab1DNHbz (ORCPT ); Thu, 14 Apr 2011 03:31:55 -0400 Received: from idefix.phytec.de (idefix.phytec.de [172.16.0.10]) by root.phytec.de (Postfix) with ESMTP id 20A92BF08A; Thu, 14 Apr 2011 09:33:59 +0200 (CEST) Received: from numalfix.phytec.de ([127.0.0.1]) by idefix.phytec.de (Lotus Domino Release 8.5.2 HF194) with ESMTP id 2011041409315409-174859 ; Thu, 14 Apr 2011 09:31:54 +0200 Received: by numalfix.phytec.de (Postfix, from userid 1001) id 0B6031A0C1F; Thu, 14 Apr 2011 09:31:53 +0200 (CEST) From: Juergen Kilb To: linux-arm-kernel@lists.infradead.org Cc: dbrownell@users.sourceforge.net, balbi@ti.com, gregkh@suse.de, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, sameo@linux.intel.com, Juergen Kilb Subject: [PATCH] Fixed gpio polarity of gpio USB-phy reset. Date: Thu, 14 Apr 2011 09:31:43 +0200 Message-Id: <1302766303-1157-1-git-send-email-J.Kilb@phytec.de> X-Mailer: git-send-email 1.7.0.4 X-MIMETrack: Itemize by SMTP Server on Idefix/Phytec(Release 8.5.2 HF194|November 09, 2010) at 14.04.2011 09:31:54, Serialize by Router on Idefix/Phytec(Release 8.5.2 HF194|November 09, 2010) at 14.04.2011 09:31:54, Serialize complete at 14.04.2011 09:31:54 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 14 Apr 2011 07:32:14 +0000 (UTC) With commit 19403165 a main part of ehci-omap.c moved to drivers/mfd/omap-usb-host.c created by commit 17cdd29d. Due to this reorganisation the polarity used to reset the external USB phy changed and USB host doesn't recognize any devices. Signed-off-by: Juergen Kilb Acked-by: Felipe Balbi Tested-by: Steve Sakoman --- drivers/mfd/omap-usb-host.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index 53450f4..491cac5 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c @@ -719,14 +719,14 @@ static int usbhs_enable(struct device *dev) gpio_request(pdata->ehci_data->reset_gpio_port[0], "USB1 PHY reset"); gpio_direction_output - (pdata->ehci_data->reset_gpio_port[0], 1); + (pdata->ehci_data->reset_gpio_port[0], 0); } if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1])) { gpio_request(pdata->ehci_data->reset_gpio_port[1], "USB2 PHY reset"); gpio_direction_output - (pdata->ehci_data->reset_gpio_port[1], 1); + (pdata->ehci_data->reset_gpio_port[1], 0); } /* Hold the PHY in RESET for enough time till DIR is high */ @@ -906,11 +906,11 @@ static int usbhs_enable(struct device *dev) if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0])) gpio_set_value - (pdata->ehci_data->reset_gpio_port[0], 0); + (pdata->ehci_data->reset_gpio_port[0], 1); if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1])) gpio_set_value - (pdata->ehci_data->reset_gpio_port[1], 0); + (pdata->ehci_data->reset_gpio_port[1], 1); } end_count: