From patchwork Thu May 12 11:30:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarkko Nikula X-Patchwork-Id: 779502 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4CBU7up006924 for ; Thu, 12 May 2011 11:30:07 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754839Ab1ELLaG (ORCPT ); Thu, 12 May 2011 07:30:06 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:42821 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754752Ab1ELLaF (ORCPT ); Thu, 12 May 2011 07:30:05 -0400 Received: by ewy4 with SMTP id 4so389368ewy.19 for ; Thu, 12 May 2011 04:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer; bh=gqfzng8bg2JmNv7DGXKvOpZ4/2bhHYH43vuZ4i61olo=; b=qWuFKfmklIwXVdRlb6hTA9SccWOq/e2z9nUZGBg09HtM8zSlrlJyGYunKT4gKFoB0X 9T0SM5mKSaGNqoGmNL1Jq2fDBh0g4WCKbHnW9+p9L2KD4PcJWlJlPiC9H4hyv07OOFsL aH9+3uVInFWdk3n94Z5eFrl/u6eO9olnJjp5Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=a9khwdjelGKtegEbVDITLc0x3d83cha6t4Gc+wCru4xSAnc6eTfpidAj1BW5iEldvu BLYP1lsENx5RkKuQ90RYJf3uWcY3fC7y3AMUMya/Xsfk4sNQO6gQ5Ag+0TdNExEYjeQE /8diVZZ0ku8vitWSO0vUGGxcN3o4IoMtGsZOM= Received: by 10.213.108.205 with SMTP id g13mr115483ebp.96.1305199803655; Thu, 12 May 2011 04:30:03 -0700 (PDT) Received: from localhost ([194.136.136.46]) by mx.google.com with ESMTPS id y10sm227243eeh.17.2011.05.12.04.30.02 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 May 2011 04:30:02 -0700 (PDT) From: Jarkko Nikula To: linux-omap@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Tony Lindgren , Jarkko Nikula , Kalle Jokiniemi Subject: [PATCH 1/2] omap: rx51: Set regulator V28_A always on Date: Thu, 12 May 2011 14:30:57 +0300 Message-Id: <1305199858-32643-1-git-send-email-jhnikula@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 12 May 2011 11:30:08 +0000 (UTC) The V28_A domain in Nokia N900 that supplies VDD voltages to TLV320AIC34 and TPA6130A2 should not be shutdown. This is because otherwise there will be leak from VIO to VDD in TLV320AIC34 and this leak consumes more battery current that is saved from keeping V28_A off. With this patch the battery current consumption is approximately 1.5 mA lower. Thanks to Kalle Jokiniemi for noticing the issue. Signed-off-by: Jarkko Nikula Cc: Kalle Jokiniemi --- arch/arm/mach-omap2/board-rx51-peripherals.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index bbcb677..8242e99 100644 --- a/arch/arm/mach-omap2/board-rx51-peripherals.c +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c @@ -464,6 +464,7 @@ static struct regulator_init_data rx51_vmmc2 = { .name = "V28_A", .min_uV = 2800000, .max_uV = 3000000, + .always_on = true, /* due VIO leak to AIC34 VDDs */ .apply_uV = true, .valid_modes_mask = REGULATOR_MODE_NORMAL | REGULATOR_MODE_STANDBY,