| Message ID | 1305199858-32643-2-git-send-email-jhnikula@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Jarkko Nikula <jhnikula@gmail.com> [110512 04:26]: > Speaker amplifier is accidentally powered up in early TWL gpio setup. This > causes a few mA of needless battery current consumption. Without this patch > the amplifier can be shutdown only by having one active audio playback and > shutdown cycle to speaker output. > > Thanks to Kalle Jokiniemi <kalle.jokiniemi@nokia.com> for noticing the issue. > > Signed-off-by: Jarkko Nikula <jhnikula@gmail.com> > Cc: Kalle Jokiniemi <kalle.jokiniemi@nokia.com> > --- > arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c > index 8242e99..0374562 100644 > --- a/arch/arm/mach-omap2/board-rx51-peripherals.c > +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c > @@ -561,7 +561,7 @@ static int rx51_twlgpio_setup(struct device *dev, unsigned gpio, unsigned n) > gpio_request(gpio + 6, "backlight_pwm"); > gpio_direction_output(gpio + 6, 0); > gpio_request(gpio + 7, "speaker_en"); > - gpio_direction_output(gpio + 7, 1); > + gpio_direction_output(gpio + 7, 0); > > return 0; > } Jarkko care to rebase this on current -rc1? Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index 8242e99..0374562 100644 --- a/arch/arm/mach-omap2/board-rx51-peripherals.c +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c @@ -561,7 +561,7 @@ static int rx51_twlgpio_setup(struct device *dev, unsigned gpio, unsigned n) gpio_request(gpio + 6, "backlight_pwm"); gpio_direction_output(gpio + 6, 0); gpio_request(gpio + 7, "speaker_en"); - gpio_direction_output(gpio + 7, 1); + gpio_direction_output(gpio + 7, 0); return 0; }
Speaker amplifier is accidentally powered up in early TWL gpio setup. This causes a few mA of needless battery current consumption. Without this patch the amplifier can be shutdown only by having one active audio playback and shutdown cycle to speaker output. Thanks to Kalle Jokiniemi <kalle.jokiniemi@nokia.com> for noticing the issue. Signed-off-by: Jarkko Nikula <jhnikula@gmail.com> Cc: Kalle Jokiniemi <kalle.jokiniemi@nokia.com> --- arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)