From patchwork Thu May 12 11:30:58 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarkko Nikula X-Patchwork-Id: 779512 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4CBUBSR006968 for ; Thu, 12 May 2011 11:30:11 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754899Ab1ELLaI (ORCPT ); Thu, 12 May 2011 07:30:08 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:42821 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754752Ab1ELLaH (ORCPT ); Thu, 12 May 2011 07:30:07 -0400 Received: by mail-ew0-f46.google.com with SMTP id 4so389368ewy.19 for ; Thu, 12 May 2011 04:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references; bh=/daZMNppP9iW6I3opeU0SLAe6MsRtjKrD/xFKQkHXGM=; b=oeY+gantA4AmKzrYmlJMosfWxbwvfXPc73F4ABgeoaEFP0JM17uFvptb+u1Ew/wLsa K1ffgsBySVDhD50oJ2eqx45QyEHMrjzm1ab28rxJEhSDslGCnZ7A9X+xgNrNcR1iroHy ddBDEaihv+ZWfYGhOYfwboonxatDPfBJO65p4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=if408I7LOVutlAHiHV9E8C//H3tXuDDoOxMdrdf1wf7igljunNuR3YIVYF2m5Q4/IG JI7OyBFQky8gsFo3qKIvJ4C8mn2GJzSIOzY5EwVm48JbA3m6TV/GoxMeOgIPAY2nVf50 /hEGciU9sZDz1qM4kOdAaC7QGjbrHfEwBP64s= Received: by 10.14.49.210 with SMTP id x58mr39934eeb.12.1305199806376; Thu, 12 May 2011 04:30:06 -0700 (PDT) Received: from localhost ([194.136.136.46]) by mx.google.com with ESMTPS id y5sm630492eeh.27.2011.05.12.04.30.05 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 May 2011 04:30:05 -0700 (PDT) From: Jarkko Nikula To: linux-omap@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Tony Lindgren , Jarkko Nikula , Kalle Jokiniemi Subject: [PATCH 2/2] omap: rx51: Don't power up speaker amplifier at bootup Date: Thu, 12 May 2011 14:30:58 +0300 Message-Id: <1305199858-32643-2-git-send-email-jhnikula@gmail.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1305199858-32643-1-git-send-email-jhnikula@gmail.com> References: <1305199858-32643-1-git-send-email-jhnikula@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 12 May 2011 11:30:11 +0000 (UTC) Speaker amplifier is accidentally powered up in early TWL gpio setup. This causes a few mA of needless battery current consumption. Without this patch the amplifier can be shutdown only by having one active audio playback and shutdown cycle to speaker output. Thanks to Kalle Jokiniemi for noticing the issue. Signed-off-by: Jarkko Nikula Cc: Kalle Jokiniemi --- arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index 8242e99..0374562 100644 --- a/arch/arm/mach-omap2/board-rx51-peripherals.c +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c @@ -561,7 +561,7 @@ static int rx51_twlgpio_setup(struct device *dev, unsigned gpio, unsigned n) gpio_request(gpio + 6, "backlight_pwm"); gpio_direction_output(gpio + 6, 0); gpio_request(gpio + 7, "speaker_en"); - gpio_direction_output(gpio + 7, 1); + gpio_direction_output(gpio + 7, 0); return 0; }