| Message ID | 1306375016-707-2-git-send-email-nm@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> -----Original Message----- > From: linux-omap-owner@vger.kernel.org > [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Menon, Nishanth > Sent: Thursday, May 26, 2011 7:27 AM > To: linux-omap > Cc: V, Aneesh; Menon, Nishanth > Subject: [RFC][PATCH 1/9] OMAP: ID: introduce chip detection > for OMAP4460 > > From: Aneesh V <aneesh@ti.com> > > Add support for detecting the latest in the OMAP4 family: OMAP4460 > Among other changes, the new chip also can support 1.5GHz A9s, > 1080p stereoscopic 3D and 12 MP stereo (dual camera). In addition, > we have changes to OPPs supported, clock tree etc, hence having a > chip detection is required. > > Starting from OMAP4460 ES1.0, we are moving from HAWKEYE to > Ramp system > for chip identification. Since the bit offsets are the same, > just rename > the variable for dual use. > > For more details on OMAP4460, see > Highlights: > http://focus.ti.com/general/docs/wtbu/wtbuproductcontent.tsp?c > ontentId=53243&navigationId=12843&templateId=6123 > Public TRM is available here as usual: > http://focus.ti.com/general/docs/wtbu/wtbudocumentcenter.tsp?t > emplateId=6123&navigationId=12667 > > [nm@ti.com: cleanups and introduction of ramp system] > Signed-off-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Aneesh V <aneesh@ti.com> > --- > arch/arm/mach-omap2/id.c | 19 ++++++++++++++----- > arch/arm/plat-omap/include/plat/cpu.h | 12 ++++++++++++ > 2 files changed, 26 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c > index 2537090..724be0a 100644 > --- a/arch/arm/mach-omap2/id.c > +++ b/arch/arm/mach-omap2/id.c > @@ -331,7 +331,7 @@ static void __init omap3_check_revision(void) > static void __init omap4_check_revision(void) > { > u32 idcode; > - u16 hawkeye; > + u16 hawkeye_ramp; [sp] Why is this change required? > u8 rev; > ~sanjeev [snip]...[snip] -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 14:03-20110526, Premi, Sanjeev wrote: > > -----Original Message----- > > From: linux-omap-owner@vger.kernel.org > > [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Menon, Nishanth > > Sent: Thursday, May 26, 2011 7:27 AM > > To: linux-omap > > Cc: V, Aneesh; Menon, Nishanth > > Subject: [RFC][PATCH 1/9] OMAP: ID: introduce chip detection > > for OMAP4460 > > > > From: Aneesh V <aneesh@ti.com> > > > > Add support for detecting the latest in the OMAP4 family: OMAP4460 > > Among other changes, the new chip also can support 1.5GHz A9s, > > 1080p stereoscopic 3D and 12 MP stereo (dual camera). In addition, > > we have changes to OPPs supported, clock tree etc, hence having a > > chip detection is required. > > > > Starting from OMAP4460 ES1.0, we are moving from HAWKEYE to > > Ramp system > > for chip identification. Since the bit offsets are the same, > > just rename > > the variable for dual use. > > > > For more details on OMAP4460, see > > Highlights: > > http://focus.ti.com/general/docs/wtbu/wtbuproductcontent.tsp?c > > ontentId=53243&navigationId=12843&templateId=6123 > > Public TRM is available here as usual: > > http://focus.ti.com/general/docs/wtbu/wtbudocumentcenter.tsp?t > > emplateId=6123&navigationId=12667 > > > > [nm@ti.com: cleanups and introduction of ramp system] > > Signed-off-by: Nishanth Menon <nm@ti.com> > > Signed-off-by: Aneesh V <aneesh@ti.com> > > --- > > arch/arm/mach-omap2/id.c | 19 ++++++++++++++----- > > arch/arm/plat-omap/include/plat/cpu.h | 12 ++++++++++++ > > 2 files changed, 26 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c > > index 2537090..724be0a 100644 > > --- a/arch/arm/mach-omap2/id.c > > +++ b/arch/arm/mach-omap2/id.c > > @@ -331,7 +331,7 @@ static void __init omap3_check_revision(void) > > static void __init omap4_check_revision(void) > > { > > u32 idcode; > > - u16 hawkeye; > > + u16 hawkeye_ramp; > > [sp] Why is this change required? As explained in the commit message, using hawkeye will not be accurate anymore for 4460 onwards. The variable naming is changed to prevent confusion in the future as we continue to use ramp_system. As far as I know, there is no unique bit to differentiate between the two and so far have been unique.
Nishanth Menon <nm@ti.com> writes: > On 14:03-20110526, Premi, Sanjeev wrote: >> > -----Original Message----- >> > From: linux-omap-owner@vger.kernel.org >> > [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Menon, Nishanth >> > Sent: Thursday, May 26, 2011 7:27 AM >> > To: linux-omap >> > Cc: V, Aneesh; Menon, Nishanth >> > Subject: [RFC][PATCH 1/9] OMAP: ID: introduce chip detection >> > for OMAP4460 >> > >> > From: Aneesh V <aneesh@ti.com> >> > >> > Add support for detecting the latest in the OMAP4 family: OMAP4460 >> > Among other changes, the new chip also can support 1.5GHz A9s, >> > 1080p stereoscopic 3D and 12 MP stereo (dual camera). In addition, >> > we have changes to OPPs supported, clock tree etc, hence having a >> > chip detection is required. >> > >> > Starting from OMAP4460 ES1.0, we are moving from HAWKEYE to >> > Ramp system >> > for chip identification. Since the bit offsets are the same, >> > just rename >> > the variable for dual use. >> > >> > For more details on OMAP4460, see >> > Highlights: >> > http://focus.ti.com/general/docs/wtbu/wtbuproductcontent.tsp?c >> > ontentId=53243&navigationId=12843&templateId=6123 >> > Public TRM is available here as usual: >> > http://focus.ti.com/general/docs/wtbu/wtbudocumentcenter.tsp?t >> > emplateId=6123&navigationId=12667 >> > >> > [nm@ti.com: cleanups and introduction of ramp system] >> > Signed-off-by: Nishanth Menon <nm@ti.com> >> > Signed-off-by: Aneesh V <aneesh@ti.com> >> > --- >> > arch/arm/mach-omap2/id.c | 19 ++++++++++++++----- >> > arch/arm/plat-omap/include/plat/cpu.h | 12 ++++++++++++ >> > 2 files changed, 26 insertions(+), 5 deletions(-) >> > >> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c >> > index 2537090..724be0a 100644 >> > --- a/arch/arm/mach-omap2/id.c >> > +++ b/arch/arm/mach-omap2/id.c >> > @@ -331,7 +331,7 @@ static void __init omap3_check_revision(void) >> > static void __init omap4_check_revision(void) >> > { >> > u32 idcode; >> > - u16 hawkeye; >> > + u16 hawkeye_ramp; >> >> [sp] Why is this change required? > As explained in the commit message, using hawkeye will not be accurate > anymore for 4460 onwards. The variable naming is changed to prevent confusion in > the future as we continue to use ramp_system. As far as I know, there is > no unique bit to differentiate between the two and so far have been > unique. So if the register is the same, and all the bit offsets are the same, what has changed? IOW, if there's no difference to the SW, then the variable rename is probably superfluous, and could be covered by a comment in the code. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 26, 2011 at 16:15, Kevin Hilman <khilman@ti.com> wrote: > Nishanth Menon <nm@ti.com> writes: > >> On 14:03-20110526, Premi, Sanjeev wrote: >>> > -----Original Message----- >>> > From: linux-omap-owner@vger.kernel.org >>> > [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Menon, Nishanth >>> > Sent: Thursday, May 26, 2011 7:27 AM >>> > To: linux-omap >>> > Cc: V, Aneesh; Menon, Nishanth >>> > Subject: [RFC][PATCH 1/9] OMAP: ID: introduce chip detection >>> > for OMAP4460 >>> > >>> > From: Aneesh V <aneesh@ti.com> >>> > >>> > Add support for detecting the latest in the OMAP4 family: OMAP4460 >>> > Among other changes, the new chip also can support 1.5GHz A9s, >>> > 1080p stereoscopic 3D and 12 MP stereo (dual camera). In addition, >>> > we have changes to OPPs supported, clock tree etc, hence having a >>> > chip detection is required. >>> > >>> > Starting from OMAP4460 ES1.0, we are moving from HAWKEYE to >>> > Ramp system >>> > for chip identification. Since the bit offsets are the same, >>> > just rename >>> > the variable for dual use. >>> > >>> > For more details on OMAP4460, see >>> > Highlights: >>> > http://focus.ti.com/general/docs/wtbu/wtbuproductcontent.tsp?c >>> > ontentId=53243&navigationId=12843&templateId=6123 >>> > Public TRM is available here as usual: >>> > http://focus.ti.com/general/docs/wtbu/wtbudocumentcenter.tsp?t >>> > emplateId=6123&navigationId=12667 >>> > >>> > [nm@ti.com: cleanups and introduction of ramp system] >>> > Signed-off-by: Nishanth Menon <nm@ti.com> >>> > Signed-off-by: Aneesh V <aneesh@ti.com> >>> > --- >>> > arch/arm/mach-omap2/id.c | 19 ++++++++++++++----- >>> > arch/arm/plat-omap/include/plat/cpu.h | 12 ++++++++++++ >>> > 2 files changed, 26 insertions(+), 5 deletions(-) >>> > >>> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c >>> > index 2537090..724be0a 100644 >>> > --- a/arch/arm/mach-omap2/id.c >>> > +++ b/arch/arm/mach-omap2/id.c >>> > @@ -331,7 +331,7 @@ static void __init omap3_check_revision(void) >>> > static void __init omap4_check_revision(void) >>> > { >>> > u32 idcode; >>> > - u16 hawkeye; >>> > + u16 hawkeye_ramp; >>> >>> [sp] Why is this change required? >> As explained in the commit message, using hawkeye will not be accurate >> anymore for 4460 onwards. The variable naming is changed to prevent confusion in >> the future as we continue to use ramp_system. As far as I know, there is >> no unique bit to differentiate between the two and so far have been >> unique. > > So if the register is the same, and all the bit offsets are the same, > what has changed? IOW, if there's no difference to the SW, then the > variable rename is probably superfluous, and could be covered by a > comment in the code. OK. that'd be easier - I agree. Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c index 2537090..724be0a 100644 --- a/arch/arm/mach-omap2/id.c +++ b/arch/arm/mach-omap2/id.c @@ -331,7 +331,7 @@ static void __init omap3_check_revision(void) static void __init omap4_check_revision(void) { u32 idcode; - u16 hawkeye; + u16 hawkeye_ramp; u8 rev; /* @@ -340,19 +340,19 @@ static void __init omap4_check_revision(void) * revision numbers as ES1.0 uses value 0. */ idcode = read_tap_reg(OMAP_TAP_IDCODE); - hawkeye = (idcode >> 12) & 0xffff; + hawkeye_ramp = (idcode >> 12) & 0xffff; rev = (idcode >> 28) & 0xf; /* - * Few initial ES2.0 samples IDCODE is same as ES1.0 + * Few initial 4430 ES2.0 samples IDCODE is same as ES1.0 * Use ARM register to detect the correct ES version */ - if (!rev) { + if (!rev && (hawkeye_ramp != 0xb94e)) { idcode = read_cpuid(CPUID_ID); rev = (idcode & 0xf) - 1; } - switch (hawkeye) { + switch (hawkeye_ramp) { case 0xb852: switch (rev) { case 0: @@ -377,6 +377,15 @@ static void __init omap4_check_revision(void) omap_chip.oc |= CHIP_IS_OMAP4430ES2_2; } break; + case 0xb94e: + switch (rev) { + case 0: + default: + omap_revision = OMAP4460_REV_ES1_0; + omap_chip.oc |= CHIP_IS_OMAP4460ES1_0; + break; + } + break; default: /* Unknown default to latest silicon rev as default */ omap_revision = OMAP4430_REV_ES2_2; diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-omap/include/plat/cpu.h index 8198bb6..d12b63d 100644 --- a/arch/arm/plat-omap/include/plat/cpu.h +++ b/arch/arm/plat-omap/include/plat/cpu.h @@ -88,6 +88,7 @@ unsigned int omap_rev(void); * cpu_is_omap243x(): True for OMAP2430 * cpu_is_omap343x(): True for OMAP3430 * cpu_is_omap443x(): True for OMAP4430 + * cpu_is_omap446x(): True for OMAP4460 */ #define GET_OMAP_CLASS (omap_rev() & 0xff) @@ -123,6 +124,7 @@ IS_OMAP_SUBCLASS(243x, 0x243) IS_OMAP_SUBCLASS(343x, 0x343) IS_OMAP_SUBCLASS(363x, 0x363) IS_OMAP_SUBCLASS(443x, 0x443) +IS_OMAP_SUBCLASS(446x, 0x446) IS_TI_SUBCLASS(816x, 0x816) @@ -137,6 +139,7 @@ IS_TI_SUBCLASS(816x, 0x816) #define cpu_is_ti816x() 0 #define cpu_is_omap44xx() 0 #define cpu_is_omap443x() 0 +#define cpu_is_omap446x() 0 #if defined(MULTI_OMAP1) # if defined(CONFIG_ARCH_OMAP730) @@ -361,8 +364,10 @@ IS_OMAP_TYPE(3517, 0x3517) # if defined(CONFIG_ARCH_OMAP4) # undef cpu_is_omap44xx # undef cpu_is_omap443x +# undef cpu_is_omap446x # define cpu_is_omap44xx() is_omap44xx() # define cpu_is_omap443x() is_omap443x() +# define cpu_is_omap446x() is_omap446x() # endif /* Macros to detect if we have OMAP1 or OMAP2 */ @@ -410,6 +415,9 @@ IS_OMAP_TYPE(3517, 0x3517) #define OMAP4430_REV_ES2_1 (OMAP443X_CLASS | (0x21 << 8)) #define OMAP4430_REV_ES2_2 (OMAP443X_CLASS | (0x22 << 8)) +#define OMAP446X_CLASS 0x44600044 +#define OMAP4460_REV_ES1_0 (OMAP446X_CLASS | (0x10 << 8)) + /* * omap_chip bits * @@ -439,6 +447,7 @@ IS_OMAP_TYPE(3517, 0x3517) #define CHIP_IS_OMAP4430ES2_1 (1 << 12) #define CHIP_IS_OMAP4430ES2_2 (1 << 13) #define CHIP_IS_TI816X (1 << 14) +#define CHIP_IS_OMAP4460ES1_0 (1 << 15) #define CHIP_IS_OMAP24XX (CHIP_IS_OMAP2420 | CHIP_IS_OMAP2430) @@ -447,6 +456,9 @@ IS_OMAP_TYPE(3517, 0x3517) CHIP_IS_OMAP4430ES2_1 | \ CHIP_IS_OMAP4430ES2_2) +#define CHIP_IS_OMAP4460 CHIP_IS_OMAP4460ES1_0 + +#define CHIP_IS_OMAP44XX (CHIP_IS_OMAP4430 | CHIP_IS_OMAP4460) /* * "GE" here represents "greater than or equal to" in terms of ES * levels. So CHIP_GE_OMAP3430ES2 is intended to match all OMAP3430