From patchwork Tue May 31 08:27:00 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarkko Nikula X-Patchwork-Id: 831662 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4V8R2df014148 for ; Tue, 31 May 2011 08:27:03 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758304Ab1EaI1A (ORCPT ); Tue, 31 May 2011 04:27:00 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:42430 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758211Ab1EaI06 (ORCPT ); Tue, 31 May 2011 04:26:58 -0400 Received: by eyx24 with SMTP id 24so1571860eyx.19 for ; Tue, 31 May 2011 01:26:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer; bh=+Gu22gfEYbKnXqY4LdSwg/qnAHfRp/87SCreELQpdYg=; b=XYiHzGnMCGJvtZ3J1r/tqHulXSo0Ga/w8eXLEQqtoolnwzJ+KOCO00l85OJ3PVQBsl wXBgtm3Ny3/2QwRUemxyDOyD3W74XqdMwJz2P5RW7GyrLXJMlVd8hlpXaKMSLz7RPAVU lTcsfFL9fF4hNm4R5tRMzCvjvr1yNig+jNpqM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=ur50hh50PkAIGx75wV7o6kzpo7HEG8bFRHEoiK3kRWIOKpQ0j0OP1lvKuszkiPW1jF sglFSBZ5vw1D8yeeDMn55eKkgDMxJ96UuorHyNWMTg5utIrHRcISLXm0cNVfd1dSdlXu XVq+9pwzI13Vf8A6ao8W9zJH061qtw5euwBRo= Received: by 10.14.127.15 with SMTP id c15mr427241eei.44.1306830417276; Tue, 31 May 2011 01:26:57 -0700 (PDT) Received: from localhost ([194.136.136.46]) by mx.google.com with ESMTPS id x3sm635157eef.17.2011.05.31.01.26.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 31 May 2011 01:26:56 -0700 (PDT) From: Jarkko Nikula To: linux-omap@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Tony Lindgren , Jarkko Nikula , Kalle Jokiniemi Subject: [PATCHv2 1/2] omap: rx51: Set regulator V28_A always on Date: Tue, 31 May 2011 11:27:00 +0300 Message-Id: <1306830421-25727-1-git-send-email-jhnikula@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 31 May 2011 08:27:03 +0000 (UTC) The V28_A domain in Nokia N900 that supplies VDD voltages to TLV320AIC34 and TPA6130A2 should not be shutdown. This is because otherwise there will be leak from VIO to VDD in TLV320AIC34 and this leak consumes more battery current that is saved from keeping V28_A off. With this patch the battery current consumption is approximately 1.5 mA lower. Thanks to Kalle Jokiniemi for noticing the issue. Signed-off-by: Jarkko Nikula Cc: Kalle Jokiniemi --- No changes from v1. Just sent together with 2/2. --- arch/arm/mach-omap2/board-rx51-peripherals.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index f6247e7..02a6587 100644 --- a/arch/arm/mach-omap2/board-rx51-peripherals.c +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c @@ -488,6 +488,7 @@ static struct regulator_init_data rx51_vmmc2 = { .name = "V28_A", .min_uV = 2800000, .max_uV = 3000000, + .always_on = true, /* due VIO leak to AIC34 VDDs */ .apply_uV = true, .valid_modes_mask = REGULATOR_MODE_NORMAL | REGULATOR_MODE_STANDBY,