| Message ID | 1309877932-27202-1-git-send-email-vishwanath.bs@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi On Tue, 5 Jul 2011, Vishwanath BS wrote: > From: Keerthy <j-keerthy@ti.com> > > Patch adds hwmod entry for 4460 thermal sensor module. Thermal sensor module > is part of Control module sharing its address space and clocked via Bandgap > Functional Clock. Adding a seperate hwmod entry for thermal sensor will > enable thermal sensor driver to manage its clock cleanly using PM runtime > interfaces. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > Signed-off-by: Vishwnath BS <vishwanath.bs@ti.com> This needs to be coordinated with Benoît, since he's the maintainer of this file. Since he's away at the moment, this is probably 3.2 material. - Paul
On Thu, Jul 7, 2011 at 2:59 PM, Paul Walmsley <paul@pwsan.com> wrote: > Hi > > On Tue, 5 Jul 2011, Vishwanath BS wrote: > >> From: Keerthy <j-keerthy@ti.com> >> >> Patch adds hwmod entry for 4460 thermal sensor module. Thermal sensor module >> is part of Control module sharing its address space and clocked via Bandgap >> Functional Clock. Adding a seperate hwmod entry for thermal sensor will >> enable thermal sensor driver to manage its clock cleanly using PM runtime >> interfaces. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> Signed-off-by: Vishwnath BS <vishwanath.bs@ti.com> > > This needs to be coordinated with Benoît, since he's the maintainer of > this file. Since he's away at the moment, this is probably 3.2 material. > Hello Paul/Tony, This hwmod is specific to OMAP4460. When i tried to compile i see that CHIP_IS_OMAP446X is missing. Since this is very much specific to OMAP4460 is there another way to differentiate between OMAP4430 and OMAP4460? > > - Paul
On Thu, Jul 21, 2011 at 8:56 PM, J, KEERTHY <j-keerthy@ti.com> wrote: > On Thu, Jul 7, 2011 at 2:59 PM, Paul Walmsley <paul@pwsan.com> wrote: >> Hi >> >> On Tue, 5 Jul 2011, Vishwanath BS wrote: >> >>> From: Keerthy <j-keerthy@ti.com> >>> >>> Patch adds hwmod entry for 4460 thermal sensor module. Thermal sensor module >>> is part of Control module sharing its address space and clocked via Bandgap >>> Functional Clock. Adding a seperate hwmod entry for thermal sensor will >>> enable thermal sensor driver to manage its clock cleanly using PM runtime >>> interfaces. >>> >>> Signed-off-by: Keerthy <j-keerthy@ti.com> >>> Signed-off-by: Vishwnath BS <vishwanath.bs@ti.com> >> >> This needs to be coordinated with Benoît, since he's the maintainer of >> this file. Since he's away at the moment, this is probably 3.2 material. >> > > Hello Paul/Tony, > > This hwmod is specific to OMAP4460. When i tried to compile i see that > CHIP_IS_OMAP446X is missing. Since this is very much specific to > OMAP4460 is there another way to differentiate between OMAP4430 and > OMAP4460? Hi Paul, Any inputs on this? > >> >> - Paul > > > > -- > Regards and Thanks, > Keerthy >
On 7/21/2011 5:26 PM, J, KEERTHY wrote: > On Thu, Jul 7, 2011 at 2:59 PM, Paul Walmsley<paul@pwsan.com> wrote: >> Hi >> >> On Tue, 5 Jul 2011, Vishwanath BS wrote: >> >>> From: Keerthy<j-keerthy@ti.com> >>> >>> Patch adds hwmod entry for 4460 thermal sensor module. Thermal sensor module >>> is part of Control module sharing its address space and clocked via Bandgap >>> Functional Clock. Adding a seperate hwmod entry for thermal sensor will >>> enable thermal sensor driver to manage its clock cleanly using PM runtime >>> interfaces. >>> >>> Signed-off-by: Keerthy<j-keerthy@ti.com> >>> Signed-off-by: Vishwnath BS<vishwanath.bs@ti.com> >> >> This needs to be coordinated with Benoît, since he's the maintainer of >> this file. Since he's away at the moment, this is probably 3.2 material. >> > > Hello Paul/Tony, > > This hwmod is specific to OMAP4460. When i tried to compile i see that > CHIP_IS_OMAP446X is missing. Since this is very much specific to > OMAP4460 is there another way to differentiate between OMAP4430 and > OMAP4460? That flag should be added by the OMAP4460 series Rajendra did. This is still the right way to identify a chip for the moment. Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c index 5e9df34..a01a9ec --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c @@ -755,6 +755,58 @@ static struct omap_hwmod omap44xx_aess_hwmod = { }; /* + * 'thermal_sensor' class + * thermal sensor module inside the bandgap / control module + */ + +static struct omap_hwmod_class omap44xx_thermal_sensor_hwmod_class = { + .name = "thermal_sensor", +}; + +static struct omap_hwmod_irq_info omap44xx_thermal_sensor_irqs[] = { + { .name = "thermal_alert", .irq = 126 + OMAP44XX_IRQ_GIC_START }, +}; + +static struct omap_hwmod_addr_space omap44xx_thermal_sensor_addrs[] = { + { + .pa_start = 0x4a002378, + .pa_end = 0x4a0023ff, + }, +}; + +static struct omap_hwmod omap44xx_thermal_sensor_hwmod; +/* l4_cfg -> ctrl_module_core */ +static struct omap_hwmod_ocp_if omap44xx_l4_cfg__thermal_sensor = { + .master = &omap44xx_l4_cfg_hwmod, + .slave = &omap44xx_thermal_sensor_hwmod, + .clk = "l4_div_ck", + .addr = omap44xx_thermal_sensor_addrs, + .addr_cnt = ARRAY_SIZE(omap44xx_thermal_sensor_addrs), + .user = OCP_USER_MPU | OCP_USER_SDMA, +}; + +/* ctrl_module_core slave ports */ +static struct omap_hwmod_ocp_if *omap44xx_thermal_sensor_slaves[] = { + &omap44xx_l4_cfg__thermal_sensor, +}; + +static struct omap_hwmod omap44xx_thermal_sensor_hwmod = { + .name = "thermal_sensor", + .class = &omap44xx_thermal_sensor_hwmod_class, + .mpu_irqs = omap44xx_thermal_sensor_irqs, + .mpu_irqs_cnt = ARRAY_SIZE(omap44xx_thermal_sensor_irqs), + .main_clk = "bandgap_ts_fclk", + .slaves = omap44xx_thermal_sensor_slaves, + .slaves_cnt = ARRAY_SIZE(omap44xx_thermal_sensor_slaves), + .prcm = { + .omap4 = { + .clkctrl_reg = OMAP4430_CM_WKUP_BANDGAP_CLKCTRL, + }, + }, + .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP446X), +}; + +/* * 'bandgap' class * bangap reference for ldo regulators */ @@ -5205,6 +5257,8 @@ static __initdata struct omap_hwmod *omap44xx_hwmods[] = { &omap44xx_timer10_hwmod, &omap44xx_timer11_hwmod, + /* thermal sensor hwmod */ + &omap44xx_thermal_sensor_hwmod, /* uart class */ &omap44xx_uart1_hwmod, &omap44xx_uart2_hwmod,