From patchwork Mon Jul 11 20:08:03 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 966242 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6BK6pkl003728 for ; Mon, 11 Jul 2011 20:18:53 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752961Ab1GKUIJ (ORCPT ); Mon, 11 Jul 2011 16:08:09 -0400 Received: from na3sys009aog115.obsmtp.com ([74.125.149.238]:39794 "EHLO na3sys009aog115.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752346Ab1GKUII (ORCPT ); Mon, 11 Jul 2011 16:08:08 -0400 Received: from mail-yx0-f171.google.com ([209.85.213.171]) (using TLSv1) by na3sys009aob115.postini.com ([74.125.148.12]) with SMTP ID DSNKThtYJ9vNCE5NCvG3ZesrH1sZ6NM4b0ZL@postini.com; Mon, 11 Jul 2011 13:08:08 PDT Received: by mail-yx0-f171.google.com with SMTP id 38so1820704yxk.30 for ; Mon, 11 Jul 2011 13:08:07 -0700 (PDT) Received: by 10.151.143.14 with SMTP id v14mr4467329ybn.132.1310414887302; Mon, 11 Jul 2011 13:08:07 -0700 (PDT) Received: from [192.168.1.215] (c-24-19-7-36.hsd1.wa.comcast.net [24.19.7.36]) by mx.google.com with ESMTPS id 37sm4156887ybv.6.2011.07.11.13.08.05 (version=SSLv3 cipher=OTHER); Mon, 11 Jul 2011 13:08:06 -0700 (PDT) Subject: Re: [PATCH] OMAP4: Keyboard: Mux changes in the board file From: Kevin Hilman To: Tony Lindgren Cc: Shubhrajyoti D , linux-omap@vger.kernel.org In-Reply-To: <20110701074824.GH23145@atomide.com> References: <1308831317-17092-1-git-send-email-shubhrajyoti@ti.com> <20110701074824.GH23145@atomide.com> Organization: Texas Instruments, Inc. Date: Mon, 11 Jul 2011 13:08:03 -0700 Message-ID: <1310414883.3077.101.camel@vence> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Mon, 11 Jul 2011 20:19:09 +0000 (UTC) On Fri, 2011-07-01 at 00:48 -0700, Tony Lindgren wrote: > * Shubhrajyoti D [110623 05:10]: > > The mux settings for keypad are done for omap4430sdp in > > board file. > > Applying into devel-board branch. > > > +static struct omap_board_data keypad_data = { > > + .id = 1, > > + .pads = keypad_pads, > > + .pads_cnt = ARRAY_SIZE(keypad_pads), > > +}; > > Aligned this struct better. This patch (and this struct) introduces another section mismatch warning because it references another struct which is __initdata but the struct itself is not: WARNING: vmlinux.o(.data+0x37788): Section mismatch in reference from the variable keypad_data to the (unknown reference) .init.data:(unknown) The variable keypad_data references the (unknown reference) __initdata (unknown) A quick glance suggests the the right fix is that this struct should also be __initdata: .pads_cnt = ARRAY_SIZE(keypad_pads), --- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c index c7cef44..66758bf 100644 --- a/arch/arm/mach-omap2/board-4430sdp.c +++ b/arch/arm/mach-omap2/board-4430sdp.c @@ -199,7 +199,7 @@ static struct omap4_keypad_platform_data sdp4430_keypad_data = { .cols = 8, }; -static struct omap_board_data keypad_data = { +static struct omap_board_data keypad_data __initdata = { .id = 1, .pads = keypad_pads,