| Message ID | 1312556561-27179-1-git-send-email-michael.jones@matrix-vision.de (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Tomi Valkeinen |
| Headers | show |
Hi all, On 08/05/2011 05:02 PM, Michael Jones wrote: > > CC drivers/video/omap2/dss/dsi.o > drivers/video/omap2/dss/dsi.c: In function ‘omap_dsi_prepare_update’: > drivers/video/omap2/dss/dsi.c:3936: warning: unused variable ‘dsidev’ > > Signed-off-by: Michael Jones <michael.jones@matrix-vision.de> > --- > drivers/video/omap2/dss/dsi.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c > index 345757c..3ae0fd8 100644 > --- a/drivers/video/omap2/dss/dsi.c > +++ b/drivers/video/omap2/dss/dsi.c > @@ -3933,7 +3933,9 @@ int omap_dsi_prepare_update(struct omap_dss_device *dssdev, > u16 *x, u16 *y, u16 *w, u16 *h, > bool enlarge_update_area) > { > +#ifdef DEBUG > struct platform_device *dsidev = dsi_get_dsidev_from_dssdev(dssdev); > +#endif > u16 dw, dh; > > dssdev->driver->get_resolution(dssdev, &dw, &dh); Upon a second look, this seems to fix a problem that doesn't exist and create one that didn't. Having reverted this patch, I don't get the warning I originally saw, and using the patch, I get a compiler error. Please disregard this submission and excuse the noise. -Michael MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c index 345757c..3ae0fd8 100644 --- a/drivers/video/omap2/dss/dsi.c +++ b/drivers/video/omap2/dss/dsi.c @@ -3933,7 +3933,9 @@ int omap_dsi_prepare_update(struct omap_dss_device *dssdev, u16 *x, u16 *y, u16 *w, u16 *h, bool enlarge_update_area) { +#ifdef DEBUG struct platform_device *dsidev = dsi_get_dsidev_from_dssdev(dssdev); +#endif u16 dw, dh; dssdev->driver->get_resolution(dssdev, &dw, &dh);
CC drivers/video/omap2/dss/dsi.o drivers/video/omap2/dss/dsi.c: In function ‘omap_dsi_prepare_update’: drivers/video/omap2/dss/dsi.c:3936: warning: unused variable ‘dsidev’ Signed-off-by: Michael Jones <michael.jones@matrix-vision.de> --- drivers/video/omap2/dss/dsi.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)